From ef4372f6720da6449783aea2ed4e4bbbdf198f58 Mon Sep 17 00:00:00 2001 From: Pierre Forstmann Date: Mon, 9 Jun 2025 14:52:36 +0200 Subject: [PATCH 1/4] chore: fix C lint errors --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c b/lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c index a0c341487b00..0a714b05f083 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c @@ -96,7 +96,7 @@ static float rand_float( void ) { */ static double benchmark1( int iterations, int len ) { double elapsed; - float x[ len ]; + float x[ len ] = {0}; /* Initialize array to silence warning */ int64_t n; double v; double t; @@ -135,7 +135,7 @@ static double benchmark1( int iterations, int len ) { */ static double benchmark2( int iterations, int len ) { double elapsed; - float x[ len ]; + float x[ len ] = {0}; /* Initialize array to silence warning */ int64_t n; double v; double t; From b0467c4fd74f754d343126cc2ed55a6bb20b95ca Mon Sep 17 00:00:00 2001 From: Pierre Forstmann Date: Mon, 9 Jun 2025 15:16:50 +0200 Subject: [PATCH 2/4] chore: fix C lint errors --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../benchmark/c/benchmark.length.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c b/lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c index 0a714b05f083..9967510e6eac 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c @@ -96,12 +96,17 @@ static float rand_float( void ) { */ static double benchmark1( int iterations, int len ) { double elapsed; - float x[ len ] = {0}; /* Initialize array to silence warning */ - int64_t n; + float x[ len ]; + CBLAS_INT n; /* silence warning about incompatible pointer type */ double v; double t; int i; + /* Initialize array to silence warning */ + for ( i = 0; i < len; i++ ) { + x[ i ] = 0; + } + for ( i = 0; i < len; i++ ) { if ( rand_float() < 0.2f ) { x[ i ] = 0.0f / 0.0f; // NaN @@ -135,12 +140,17 @@ static double benchmark1( int iterations, int len ) { */ static double benchmark2( int iterations, int len ) { double elapsed; - float x[ len ] = {0}; /* Initialize array to silence warning */ - int64_t n; + float x[ len ]; + CBLAS_INT n; /* silence warning about incompatible pointer type */ double v; double t; int i; + /* Initialize array to silence warning */ + for ( i = 0; i < len; i++ ) { + x[ i ] = 0; + } + for ( i = 0; i < len; i++ ) { if ( rand_float() < 0.2f ) { x[ i ] = 0.0f / 0.0f; // NaN From 222f82c687b043e8c024376e7007d77b9d30a117 Mon Sep 17 00:00:00 2001 From: Pierre Forstmann Date: Mon, 9 Jun 2025 15:38:42 +0200 Subject: [PATCH 3/4] chore: fix C lint errors --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../base/dsnannsumors/benchmark/c/benchmark.length.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c b/lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c index 9967510e6eac..47ea214eb2bc 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c @@ -102,11 +102,6 @@ static double benchmark1( int iterations, int len ) { double t; int i; - /* Initialize array to silence warning */ - for ( i = 0; i < len; i++ ) { - x[ i ] = 0; - } - for ( i = 0; i < len; i++ ) { if ( rand_float() < 0.2f ) { x[ i ] = 0.0f / 0.0f; // NaN @@ -118,6 +113,7 @@ static double benchmark1( int iterations, int len ) { n = 0; t = tic(); for ( i = 0; i < iterations; i++ ) { + /* cppcheck-suppress uninitvar */ v = stdlib_strided_dsnannsumors( len, x, 1, &n ); if ( v != v || n < 0 ) { printf( "should not return NaN\n" ); @@ -146,11 +142,6 @@ static double benchmark2( int iterations, int len ) { double t; int i; - /* Initialize array to silence warning */ - for ( i = 0; i < len; i++ ) { - x[ i ] = 0; - } - for ( i = 0; i < len; i++ ) { if ( rand_float() < 0.2f ) { x[ i ] = 0.0f / 0.0f; // NaN @@ -162,6 +153,7 @@ static double benchmark2( int iterations, int len ) { n = 0; t = tic(); for ( i = 0; i < iterations; i++ ) { + /* cppcheck-suppress uninitvar */ v = stdlib_strided_dsnannsumors_ndarray( len, x, 1, 0, &n ); if ( v != v || n < 0 ) { printf( "should not return NaN\n" ); From aa9235cdb7b4323928a446785bd36cff445f1313 Mon Sep 17 00:00:00 2001 From: Athan Date: Mon, 9 Jun 2025 16:44:18 -0700 Subject: [PATCH 4/4] Apply suggestions from code review Signed-off-by: Athan --- .../blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c b/lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c index 47ea214eb2bc..0dae157264c7 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/benchmark/c/benchmark.length.c @@ -97,7 +97,7 @@ static float rand_float( void ) { static double benchmark1( int iterations, int len ) { double elapsed; float x[ len ]; - CBLAS_INT n; /* silence warning about incompatible pointer type */ + CBLAS_INT n; double v; double t; int i; @@ -137,7 +137,7 @@ static double benchmark1( int iterations, int len ) { static double benchmark2( int iterations, int len ) { double elapsed; float x[ len ]; - CBLAS_INT n; /* silence warning about incompatible pointer type */ + CBLAS_INT n; double v; double t; int i;