From f5cfcb6c5c6281a6004e72ea236da5f9b1078408 Mon Sep 17 00:00:00 2001 From: Lokeshranjan8 Date: Sat, 14 Jun 2025 10:50:55 +0530 Subject: [PATCH 1/3] chore: fix JavaScript lint errors (issue #7350) --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../@stdlib/utils/async/parallel/lib/limit.js | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/node_modules/@stdlib/utils/async/parallel/lib/limit.js b/lib/node_modules/@stdlib/utils/async/parallel/lib/limit.js index 789164a68af3..c1d5d9ea5efe 100644 --- a/lib/node_modules/@stdlib/utils/async/parallel/lib/limit.js +++ b/lib/node_modules/@stdlib/utils/async/parallel/lib/limit.js @@ -54,7 +54,7 @@ function limit( fcns, opts, done ) { len = fcns.length; debug( 'Number of functions: %d', len ); - out = new Array( len ); + out = []; if ( len < opts.limit ) { lim = len; } else { @@ -77,13 +77,8 @@ function limit( fcns, opts, done ) { * @private */ function next() { - var i; - idx += 1; - // Cache the current index value to allow storing results later: - i = idx; - fcns[ idx ].call( opts.thisArg, resolve ); /** @@ -103,7 +98,7 @@ function limit( fcns, opts, done ) { flg = true; return clbk( error ); } - out[ i ] = results; + out.push( results); clbk(); } } From 9b659689f7fb20eaf9bb7db8853eb5173c90fe9e Mon Sep 17 00:00:00 2001 From: Lokeshranjan8 Date: Sat, 14 Jun 2025 11:45:39 +0530 Subject: [PATCH 2/3] fix: replace new Array(len) for lint compliance --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- lib/node_modules/@stdlib/utils/async/parallel/lib/limit.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/utils/async/parallel/lib/limit.js b/lib/node_modules/@stdlib/utils/async/parallel/lib/limit.js index c1d5d9ea5efe..9dab7938212f 100644 --- a/lib/node_modules/@stdlib/utils/async/parallel/lib/limit.js +++ b/lib/node_modules/@stdlib/utils/async/parallel/lib/limit.js @@ -77,8 +77,13 @@ function limit( fcns, opts, done ) { * @private */ function next() { + var i; + idx += 1; + // Cache the current index value to allow storing results later: + i = idx; + fcns[ idx ].call( opts.thisArg, resolve ); /** @@ -98,7 +103,7 @@ function limit( fcns, opts, done ) { flg = true; return clbk( error ); } - out.push( results); + out[ i ] = results; clbk(); } } From 9637ea3ccdebb5ce956b97dea2a8dfdc6eccc307 Mon Sep 17 00:00:00 2001 From: Athan Date: Sat, 14 Jun 2025 01:55:23 -0700 Subject: [PATCH 3/3] fix: revert change and disable lint rule Signed-off-by: Athan --- lib/node_modules/@stdlib/utils/async/parallel/lib/limit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/utils/async/parallel/lib/limit.js b/lib/node_modules/@stdlib/utils/async/parallel/lib/limit.js index 9dab7938212f..3240929dd0d3 100644 --- a/lib/node_modules/@stdlib/utils/async/parallel/lib/limit.js +++ b/lib/node_modules/@stdlib/utils/async/parallel/lib/limit.js @@ -54,7 +54,7 @@ function limit( fcns, opts, done ) { len = fcns.length; debug( 'Number of functions: %d', len ); - out = []; + out = new Array( len ); // eslint-disable-line stdlib/no-new-array if ( len < opts.limit ) { lim = len; } else {