feat: add `assign` and `strided` methods to `complex/float64/base/div` #7771

aayush0325 · 2025-07-29T06:45:56Z

Description

What is the purpose of this pull request?

This pull request:

adds assign and strided methods to complex/float64/base/div

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2025-07-29T06:48:06Z

Coverage Report

Package	Statements	Branches	Functions	Lines
complex/float64/base/div	$\color{green}466/466$ $\color{green}+100.00\%$	$\color{green}25/25$ $\color{green}+100.00\%$	$\color{green}6/6$ $\color{green}+100.00\%$	$\color{green}466/466$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

aayush0325 · 2025-07-30T06:37:34Z

/stdlib update-copyright-years

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/complex/float64/base/div/README.md

lib/node_modules/@stdlib/complex/float64/base/div/docs/types/test.ts

lib/node_modules/@stdlib/complex/float64/base/div/test/test.strided.js

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

kgryte · 2025-08-12T02:50:20Z

lib/node_modules/@stdlib/complex/float64/base/div/test/test.assign.js

+	out = new Float64Array( 2 );
+	v = cdiv( 1.0e308, 5.0e307, 1.0, 0.5, out, 1, 0 );
+	expected = new Float64Array( [ 1.0e308, 0.0 ] );
+	t.strictEqual( isAlmostEqualFloat64Array( v, expected, EPS ), true, 'returns expected values' );


@aayush0325 This is still wrong. EPS is not what should be passed into isAlmostEqualFloat64Array. Please read the docs. Ref: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/assert/is-almost-equal-float64array

kgryte · 2025-08-12T02:50:49Z

lib/node_modules/@stdlib/complex/float64/base/div/test/test.strided.js

+
+	v = cdiv( z1, 1, 0, z2, 1, 0, out, 1, 0 );
+
+	t.strictEqual( isAlmostEqualFloat64Array( v, expected, EPS ), true, 'returns expected values' );


@aayush0325 Same comment. Read the docs.

kgryte

Apart from the tests, this PR is shaping up. In principle, we could more generally clean up the tests. Namely, all the approximate equality tests using EPS and bitdiff could be rewritten to simply use isAlmostEqualFloat64Array, but that can be left to another PR. Would be good, however, to create an issue or internal TODO for this so that we don't forget.

aayush0325 marked this pull request as draft July 29, 2025 06:46

stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Jul 29, 2025

aayush0325 added Needs Review A pull request which needs code review. GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). labels Jul 29, 2025

aayush0325 added 5 commits July 30, 2025 02:39

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 30, 2025

chore: update copyright years

5d1fffa

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 30, 2025

aayush0325 added 2 commits July 30, 2025 18:35

aayush0325 marked this pull request as ready for review July 30, 2025 13:35

aayush0325 assigned aayush0325 and kgryte and unassigned aayush0325 Jul 30, 2025

kgryte reviewed Jul 30, 2025

View reviewed changes

lib/node_modules/@stdlib/complex/float64/base/div/README.md Outdated Show resolved Hide resolved

kgryte reviewed Jul 30, 2025

View reviewed changes

lib/node_modules/@stdlib/complex/float64/base/div/README.md Outdated Show resolved Hide resolved

kgryte reviewed Jul 30, 2025

View reviewed changes

lib/node_modules/@stdlib/complex/float64/base/div/docs/types/test.ts Show resolved Hide resolved

kgryte reviewed Jul 30, 2025

View reviewed changes

lib/node_modules/@stdlib/complex/float64/base/div/test/test.strided.js Outdated Show resolved Hide resolved

aayush0325 added 2 commits August 2, 2025 18:31

aayush0325 requested a review from kgryte August 2, 2025 13:11

aayush0325 mentioned this pull request Aug 4, 2025

Weekly Standup (2025-08-04) stdlib-js/google-summer-of-code#165

Closed

kgryte reviewed Aug 12, 2025

View reviewed changes

kgryte requested changes Aug 12, 2025

View reviewed changes

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Aug 12, 2025

kgryte mentioned this pull request Aug 12, 2025

feat: add lapack/base/dladiv2 #7755

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add `assign` and `strided` methods to `complex/float64/base/div` #7771

feat: add `assign` and `strided` methods to `complex/float64/base/div` #7771

Uh oh!

aayush0325 commented Jul 29, 2025

Uh oh!

stdlib-bot commented Jul 29, 2025 •

edited

Loading

Uh oh!

aayush0325 commented Jul 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kgryte Aug 12, 2025

Uh oh!

kgryte Aug 12, 2025

Uh oh!

kgryte left a comment

Uh oh!

Uh oh!


		v = cdiv( z1, 1, 0, z2, 1, 0, out, 1, 0 );

		t.strictEqual( isAlmostEqualFloat64Array( v, expected, EPS ), true, 'returns expected values' );

Uh oh!

feat: add assign and strided methods to complex/float64/base/div #7771

Are you sure you want to change the base?

feat: add assign and strided methods to complex/float64/base/div #7771

Uh oh!

Conversation

aayush0325 commented Jul 29, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

aayush0325 commented Jul 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kgryte Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

kgryte Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

feat: add `assign` and `strided` methods to `complex/float64/base/div` #7771

feat: add `assign` and `strided` methods to `complex/float64/base/div` #7771

stdlib-bot commented Jul 29, 2025 •

edited

Loading