Skip to content

chore: resolve JavaScript lint errors #8013 #8018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kgryte merged 4 commits into from
Sep 6, 2025
Merged

chore: resolve JavaScript lint errors #8013 #8018

kgryte merged 4 commits into from
Sep 6, 2025
+32 −46

Conversation

@Gauravkaushik-1206
Copy link
Contributor

@Gauravkaushik-1206 Gauravkaushik-1206 commented Sep 5, 2025 •
edited
Loading

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: na
  • task: lint_package_json status: na
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: na
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: na
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Resolves #8013

Description

What is the purpose of this pull request?

This pull request:

  • Updated the onExists function to handle the callback error.
  • Replaced the new Array() with [].

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

The test expect us to move futher to parent diectory even if we have recieve error like path does not exist, permission denied or Invalid. So, I have just added the coment that we can log the error or handle the error and moved to next diectory(parent). does i have to log the error or handle the error ??. The test cases expect us to ignore them.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Gauravkaushik-1206
fix: resolve the javascript lint error
b51a043 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Sep 5, 2025

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Sep 5, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Sep 5, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
assert/deep-equal $\color{green}178/178$
$\color{green}+100.00\%$ 		$\color{green}36/36$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}178/178$
$\color{green}+100.00\%$
fs/resolve-parent-path-by $\color{red}385/388$
$\color{green}+99.23\%$ 		$\color{red}48/50$
$\color{green}+96.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{red}385/388$
$\color{green}+99.23\%$
stats/ranks $\color{red}491/493$
$\color{green}+99.59\%$ 		$\color{red}67/68$
$\color{green}+98.53\%$ 		$\color{green}7/7$
$\color{green}+100.00\%$ 		$\color{red}491/493$
$\color{green}+99.59\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte reviewed Sep 5, 2025
View reviewed changes
kgryte
kgryte reviewed Sep 5, 2025
View reviewed changes
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Sep 5, 2025
@Gauravkaushik-1206
fix: update stats/ranks readme file
c9879b0 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Sep 6, 2025
kgryte
kgryte approved these changes Sep 6, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte changed the title fix: resolve the javascript lint error #8013 chore: resolve JavaScript lint errors #8013 Sep 6, 2025
@kgryte kgryte merged commit afee9b8 into stdlib-js:develop Sep 6, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants

@Gauravkaushik-1206 @stdlib-bot @kgryte