Skip to content

Conversation

@SuYaSh-PaThAk04
Copy link
Contributor

Resolves #8140 .

Description

What is the purpose of this pull request?
fix javascript lint errors

This pull request:

  • This pull request fixes the JavaScript linting workflow failure caused by a missing beep.js reference.
    Specifically, the eslint-files Makefile target has been updated to skip missing files instead of failing the workflow.
    This ensures that unused/removed files do not break CI lint checks.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.
Before: ESLint workflow failed with

Error: ENOENT: no such file or directory, stat './beep.js'

After: Missing files are gracefully skipped with

Skipping missing file: beep.js

This prevents false negatives during lint checks while keeping existing ESLint validations intact.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Sep 26, 2025
@SuYaSh-PaThAk04 SuYaSh-PaThAk04 changed the title "chore: fix JavaScript lint errors (issue #8140)" fix JavaScript lint errors (issue #8140) Sep 26, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuYaSh-PaThAk04 This is not the desired change. You shouldn't be changing our make recipes unless there is an actual bug with the make recipes. As such, I am going to close this PR.

@kgryte kgryte added Invalid Invalid question, issue, or pull request. and removed Needs Review A pull request which needs code review. labels Sep 28, 2025
@kgryte kgryte closed this Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Invalid Invalid question, issue, or pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants