From 341d0aef5b3ccb28b933fb0d580aa04c49229f15 Mon Sep 17 00:00:00 2001 From: Ayushi Jain Date: Wed, 7 Jan 2026 14:09:28 +0000 Subject: [PATCH 1/4] bench: refactor to use string interpolation in mathjs --- .../migration-guides/mathjs/benchmark/benchmark.subtract.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/migration-guides/mathjs/benchmark/benchmark.subtract.js b/docs/migration-guides/mathjs/benchmark/benchmark.subtract.js index 24512a323219..1f2e89f5a6fb 100644 --- a/docs/migration-guides/mathjs/benchmark/benchmark.subtract.js +++ b/docs/migration-guides/mathjs/benchmark/benchmark.subtract.js @@ -28,7 +28,7 @@ var uniform = require( '@stdlib/random/base/uniform' ).factory; var base = require( '@stdlib/number/float64/base/sub' ); var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; - +var format = require( '@stdlib/string/format' ); // VARIABLES // @@ -40,7 +40,7 @@ var opts = { // MAIN // -bench( pkg+'::stdlib:number/float64/base/sub:value=number', opts, function benchmark( b ) { +bench( format( '%s::stdlib:number/float64/base/sub:value=number' , pkg ), opts, function benchmark( b ) { var x; var y; var z; @@ -68,7 +68,7 @@ bench( pkg+'::stdlib:number/float64/base/sub:value=number', opts, function bench // TODO: add math/ops/sub benchmarks -bench( pkg+'::mathjs:subtract:value=number', opts, function benchmark( b ) { +bench( format( '%s::mathjs:subtract:value=number' , pkg ), opts, function benchmark( b ) { var x; var y; var z; From 35e9795b19c5275dd1afeac648ac33173a24a51c Mon Sep 17 00:00:00 2001 From: Athan Date: Fri, 9 Jan 2026 00:19:42 -0800 Subject: [PATCH 2/4] Apply suggestions from code review Signed-off-by: Athan --- docs/migration-guides/mathjs/benchmark/benchmark.subtract.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/migration-guides/mathjs/benchmark/benchmark.subtract.js b/docs/migration-guides/mathjs/benchmark/benchmark.subtract.js index 1f2e89f5a6fb..f55cdec27a87 100644 --- a/docs/migration-guides/mathjs/benchmark/benchmark.subtract.js +++ b/docs/migration-guides/mathjs/benchmark/benchmark.subtract.js @@ -26,9 +26,9 @@ var isnan = require( '@stdlib/math/base/assert/is-nan' ); var filledBy = require( '@stdlib/array/filled-by' ); var uniform = require( '@stdlib/random/base/uniform' ).factory; var base = require( '@stdlib/number/float64/base/sub' ); +var format = require( '@stdlib/string/format' ); var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; -var format = require( '@stdlib/string/format' ); // VARIABLES // From ebb3bf893f1fb54d516d82b72715944f69508eff Mon Sep 17 00:00:00 2001 From: Athan Date: Fri, 9 Jan 2026 00:20:07 -0800 Subject: [PATCH 3/4] style: add empty line Signed-off-by: Athan --- docs/migration-guides/mathjs/benchmark/benchmark.subtract.js | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/migration-guides/mathjs/benchmark/benchmark.subtract.js b/docs/migration-guides/mathjs/benchmark/benchmark.subtract.js index f55cdec27a87..9db298c62fdb 100644 --- a/docs/migration-guides/mathjs/benchmark/benchmark.subtract.js +++ b/docs/migration-guides/mathjs/benchmark/benchmark.subtract.js @@ -30,6 +30,7 @@ var format = require( '@stdlib/string/format' ); var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; + // VARIABLES // var mathjs = tryRequire( resolve( __dirname, '..', 'node_modules', 'mathjs' ) ); From 215e61a8e8f1448eb998d27a0e8eecce088cea6f Mon Sep 17 00:00:00 2001 From: Athan Date: Fri, 9 Jan 2026 00:24:15 -0800 Subject: [PATCH 4/4] Apply suggestions from code review Signed-off-by: Athan --- docs/migration-guides/mathjs/benchmark/benchmark.subtract.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/migration-guides/mathjs/benchmark/benchmark.subtract.js b/docs/migration-guides/mathjs/benchmark/benchmark.subtract.js index 9db298c62fdb..d4b4761fa968 100644 --- a/docs/migration-guides/mathjs/benchmark/benchmark.subtract.js +++ b/docs/migration-guides/mathjs/benchmark/benchmark.subtract.js @@ -41,7 +41,7 @@ var opts = { // MAIN // -bench( format( '%s::stdlib:number/float64/base/sub:value=number' , pkg ), opts, function benchmark( b ) { +bench( format( '%s::stdlib:number/float64/base/sub:value=number', pkg ), opts, function benchmark( b ) { var x; var y; var z; @@ -69,7 +69,7 @@ bench( format( '%s::stdlib:number/float64/base/sub:value=number' , pkg ), opts, // TODO: add math/ops/sub benchmarks -bench( format( '%s::mathjs:subtract:value=number' , pkg ), opts, function benchmark( b ) { +bench( format( '%s::mathjs:subtract:value=number', pkg ), opts, function benchmark( b ) { var x; var y; var z;