Skip to content

Commit 8504bf3

Browse files
committed
Tiling: fix edge case
1 parent 76dda6a commit 8504bf3

File tree

1 file changed

+17
-9
lines changed

1 file changed

+17
-9
lines changed

ggml_extend.hpp

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,9 @@ __STATIC_INLINE__ void ggml_merge_tensor_2d(struct ggml_tensor* input,
469469
int x,
470470
int y,
471471
int overlap_x,
472-
int overlap_y) {
472+
int overlap_y,
473+
int x_skip = 0,
474+
int y_skip = 0) {
473475
int64_t width = input->ne[0];
474476
int64_t height = input->ne[1];
475477
int64_t channels = input->ne[2];
@@ -478,16 +480,16 @@ __STATIC_INLINE__ void ggml_merge_tensor_2d(struct ggml_tensor* input,
478480
int64_t img_height = output->ne[1];
479481

480482
GGML_ASSERT(input->type == GGML_TYPE_F32 && output->type == GGML_TYPE_F32);
481-
for (int iy = 0; iy < height; iy++) {
482-
for (int ix = 0; ix < width; ix++) {
483+
for (int iy = y_skip; iy < height; iy++) {
484+
for (int ix = x_skip; ix < width; ix++) {
483485
for (int k = 0; k < channels; k++) {
484486
float new_value = ggml_tensor_get_f32(input, ix, iy, k);
485487
if (overlap_x > 0 && overlap_y > 0) { // blend colors in overlapped area
486488
float old_value = ggml_tensor_get_f32(output, x + ix, y + iy, k);
487489

488-
const float x_f_0 = (overlap_x > 0 && x > 0) ? ix / float(overlap_x) : 1;
490+
const float x_f_0 = (overlap_x > 0 && x > 0) ? (ix - x_skip) / float(overlap_x) : 1;
489491
const float x_f_1 = (overlap_x > 0 && x < (img_width - width)) ? (width - ix) / float(overlap_x) : 1;
490-
const float y_f_0 = (overlap_y > 0 && y > 0) ? iy / float(overlap_y) : 1;
492+
const float y_f_0 = (overlap_y > 0 && y > 0) ? (iy - y_skip) / float(overlap_y) : 1;
491493
const float y_f_1 = (overlap_y > 0 && y < (img_height - height)) ? (height - iy) / float(overlap_y) : 1;
492494

493495
const float x_f = std::min(std::min(x_f_0, x_f_1), 1.f);
@@ -618,10 +620,10 @@ __STATIC_INLINE__ void sd_tiling(ggml_tensor* input, ggml_tensor* output, const
618620
input_tile_size = tile_size * scale;
619621
output_tile_size = tile_size;
620622
}
621-
int num_tiles_x = (float)(input_width - input_tile_size * tile_overlap_factor) / (float)(input_tile_size * (1 - tile_overlap_factor));
623+
int num_tiles_x = (input_width - (int)(input_tile_size * tile_overlap_factor)) / (int)(input_tile_size * (1 - tile_overlap_factor));
622624
float tile_overlap_factor_x = (float)(input_tile_size * num_tiles_x - input_width) / (float)(input_tile_size * (num_tiles_x - 1));
623625

624-
int num_tiles_y = (float)(input_height - input_tile_size * tile_overlap_factor) / (float)(input_tile_size * (1 - tile_overlap_factor));
626+
int num_tiles_y = (input_height - (int)(input_tile_size * tile_overlap_factor)) / (int)(input_tile_size * (1 - tile_overlap_factor));
625627
float tile_overlap_factor_y = (float)(input_tile_size * num_tiles_y - input_height) / (float)(input_tile_size * (num_tiles_y - 1));
626628

627629
LOG_DEBUG("optimal overlap : %f, %f (targeting %f)", tile_overlap_factor_x, tile_overlap_factor_y, tile_overlap_factor);
@@ -661,22 +663,28 @@ __STATIC_INLINE__ void sd_tiling(ggml_tensor* input, ggml_tensor* output, const
661663
bool last_y = false, last_x = false;
662664
float last_time = 0.0f;
663665
for (int y = 0; y < input_height && !last_y; y += non_tile_overlap_y) {
666+
int dy = 0;
664667
if (y + input_tile_size >= input_height) {
668+
int _y = y;
665669
y = input_height - input_tile_size;
670+
dy = _y - y;
666671
last_y = true;
667672
}
668673
for (int x = 0; x < input_width && !last_x; x += non_tile_overlap_x) {
674+
int dx = 0;
669675
if (x + input_tile_size >= input_width) {
676+
int _x = x;
670677
x = input_width - input_tile_size;
678+
dx = _x - x;
671679
last_x = true;
672680
}
673681
int64_t t1 = ggml_time_ms();
674682
ggml_split_tensor_2d(input, input_tile, x, y);
675683
on_processing(input_tile, output_tile, false);
676684
if (scaled_out) {
677-
ggml_merge_tensor_2d(output_tile, output, x * scale, y * scale, tile_overlap_x * scale, tile_overlap_y * scale);
685+
ggml_merge_tensor_2d(output_tile, output, x * scale, y * scale, tile_overlap_x * scale, tile_overlap_y * scale, dx * scale, dy * scale);
678686
} else {
679-
ggml_merge_tensor_2d(output_tile, output, x / scale, y / scale, tile_overlap_x / scale, tile_overlap_y / scale);
687+
ggml_merge_tensor_2d(output_tile, output, x / scale, y / scale, tile_overlap_x / scale, tile_overlap_y / scale, dx / scale, dy / scale);
680688
}
681689
int64_t t2 = ggml_time_ms();
682690
last_time = (t2 - t1) / 1000.0f;

0 commit comments

Comments
 (0)