Do not complete hidden commands (#75)

- Extract logic for getting commands
- Hide _completion command (only if setHidden is supported)
- Use existing behaviour where setHidden isn't supported (pre Symfony 3.2)

Resolves #74

Author: Programie

src/CompletionCommand.php

@@ -33,6 +33,11 @@ protected function configure()
 
 END
             );
+
+        // setHidden() method was not available before Symfony 3.2
+        if (method_exists($this, 'setHidden')) {
+            $this->setHidden(true);
+        }
     }
 
     /**

src/CompletionHandler.php

@@ -44,7 +44,7 @@ public function __construct(Application $application, CompletionContext $context
                 'help',
                 'command_name',
                 Completion::TYPE_ARGUMENT,
-                array_keys($application->all())
+                $this->getCommandNames()
             )
         );
 
@@ -256,14 +256,7 @@ protected function completeForOptionValues()
     protected function completeForCommandName()
     {
         if (!$this->command || (count($this->context->getWords()) == 2 && $this->context->getWordIndex() == 1)) {
-            $commands = $this->application->all();
-            $names = array_keys($commands);
-
-            if ($key = array_search('_completion', $names)) {
-                unset($names[$key]);
-            }
-
-            return $names;
+            return $this->getCommandNames();
         }
 
         return false;
@@ -442,4 +435,29 @@ protected function getAllOptions()
             $this->application->getDefinition()->getOptions()
         );
     }
+
+    protected function getCommandNames()
+    {
+        $commands = array();
+
+        if (method_exists('\Symfony\Component\Console\Command\Command', 'isHidden')) {
+            foreach ($this->application->all() as $name => $command) {
+                if ($command->isHidden()) {
+                    continue;
+                }
+
+                $commands[] = $name;
+            }
+        } else {
+            foreach ($this->application->all() as $name => $command) {
+                if ($name === '_completion') {
+                    continue;
+                }
+
+                $commands[] = $name;
+            }
+        }
+
+        return $commands;
+    }
 }

tests/Stecman/Component/Symfony/Console/BashCompletion/Common/CompletionHandlerTestCase.php

@@ -19,6 +19,7 @@ abstract class CompletionHandlerTestCase extends \PHPUnit_Framework_TestCase
     public static function setUpBeforeClass()
     {
         require_once __DIR__ . '/../Fixtures/CompletionAwareCommand.php';
+        require_once __DIR__ . '/../Fixtures/HiddenCommand.php';
         require_once __DIR__ . '/../Fixtures/TestBasicCommand.php';
         require_once __DIR__ . '/../Fixtures/TestSymfonyStyleCommand.php';
     }
@@ -31,6 +32,10 @@ protected function setUp()
             new \TestBasicCommand(),
             new \TestSymfonyStyleCommand()
         ));
+
+        if (method_exists('\HiddenCommand', 'setHidden')) {
+            $this->application->add(new \HiddenCommand());
+        }
     }
 
     /**

tests/Stecman/Component/Symfony/Console/BashCompletion/Fixtures/HiddenCommand.php

@@ -0,0 +1,11 @@
+<?php
+
+
+class HiddenCommand extends \Symfony\Component\Console\Command\Command
+{
+    protected function configure()
+    {
+        $this->setName('internals')
+            ->setHidden(true);
+    }
+}