Sanitise program name when using in shell function name

Fixes #49

Author: stecman

src/HookFactory.php

@@ -64,7 +64,7 @@ function %%function_name%% {
     __ltrim_colon_completions "$cur";
 };
 
-complete -F %%function_name%% %%program_name%%;
+complete -F %%function_name%% "%%program_name%%";
 END
 
         // ZSH Hook
@@ -94,7 +94,7 @@ function %%function_name%% {
     compadd -- $RESULT
 };
 
-compdef %%function_name%% %%program_name%%;
+compdef %%function_name%% "%%program_name%%";
 END
     );
 
@@ -161,11 +161,24 @@ protected function generateFunctionName($programPath, $programName)
     {
         return sprintf(
             '_%s_%s_complete',
-            basename($programName),
+            $this->sanitiseForFunctionName(basename($programName)),
             substr(md5($programPath), 0, 16)
         );
     }
 
+
+    /**
+     * Make a string safe for use as a shell function name
+     * 
+     * @param string $name
+     * @return string
+     */
+    protected function sanitiseForFunctionName($name)
+    {
+        $name = str_replace('-', '_', $name);
+        return preg_replace('/[^A-Za-z0-9_]+/', '', $name);
+    }
+
     /**
      * Strip '#' style comments from a string
      *

tests/Stecman/Component/Symfony/Console/BashCompletion/HookFactoryTest.php

@@ -49,6 +49,7 @@ public function generateHookDataProvider()
             array('/path/to/myprogram', null, true),
             array('/path/to/myprogram', 'myprogram', false),
             array('/path/to/myprogram', 'myprogram', true),
+            array('/path/to/my-program', 'my-program', false)
         );
     }