Skip to content

Commit 54d200a

Browse files
fixed packing integer ranges
1 parent c26d942 commit 54d200a

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

Packer.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -127,22 +127,22 @@ private function packInteger(int $value): string
127127
$tmp = unpack('S', "\x01\x00");
128128
$little = $tmp[1] == 1;
129129

130-
if ($value > -1 && $value < 127) { //+TINY_INT
130+
if ($value >= 0 && $value <= 127) { //+TINY_INT
131131
$packed = pack('C', 0b00000000 | $value);
132132
$output .= $little ? strrev($packed) : $packed;
133-
} elseif ($value > -16 && $value < 0) { //-TINY_INT
133+
} elseif ($value >= -16 && $value < 0) { //-TINY_INT
134134
$packed = pack('c', 0b11110000 | $value);
135135
$output .= $little ? strrev($packed) : $packed;
136-
} elseif ($value > -128 && $value < -17) { //INT_8
136+
} elseif ($value >= -128 && $value <= -17) { //INT_8
137137
$packed = pack('c', $value);
138138
$output .= chr(0xC8) . ($little ? strrev($packed) : $packed);
139-
} elseif (($value > 128 && $value < 32767) || ($value > -32768 && $value < -129)) { //INT_16
139+
} elseif (($value >= 128 && $value <= 32767) || ($value >= -32768 && $value <= -129)) { //INT_16
140140
$packed = pack('s', $value);
141141
$output .= chr(0xC9) . ($little ? strrev($packed) : $packed);
142-
} elseif (($value > 32768 && $value < 2147483647) || ($value > -2147483648 && $value < -32769)) { //INT_32
142+
} elseif (($value >= 32768 && $value <= 2147483647) || ($value >= -2147483648 && $value <= -32769)) { //INT_32
143143
$packed = pack('l', $value);
144144
$output .= chr(0xCA) . ($little ? strrev($packed) : $packed);
145-
} elseif (($value > 2147483648 && $value < 9223372036854775807) || ($value > -9223372036854775808 && $value < -2147483649)) { //INT_64
145+
} elseif (($value >= 2147483648 && $value <= 9223372036854775807) || ($value >= -9223372036854775808 && $value <= -2147483649)) { //INT_64
146146
$packed = pack('q', $value);
147147
$output .= chr(0xCB) . ($little ? strrev($packed) : $packed);
148148
} else {

0 commit comments

Comments
 (0)