Removed arguments for method where there is no message arguments. Updated phpunit tests.

Author: stefanak-michal

README.md

@@ -1,7 +1,7 @@
 # Bolt
 Bolt protocol library over TCP socket. Bolt protocol is created and in use for communication with [Neo4j](https://neo4j.com/) Graph database. The documentation is available at [https://7687.org/](https://7687.org/). This library is aimed to be low level and keep up with protocol messages architecture and specifications.
 
-![](https://img.shields.io/badge/phpunit-passed-success) ![](https://img.shields.io/badge/coverage-87%25-green) ![](https://img.shields.io/github/stars/stefanak-michal/Bolt) ![](https://img.shields.io/packagist/dt/stefanak-michal/bolt) ![](https://img.shields.io/github/v/release/stefanak-michal/bolt) ![](https://img.shields.io/github/commits-since/stefanak-michal/bolt/latest)
+![](https://img.shields.io/badge/phpunit-passed-success) ![](https://img.shields.io/badge/coverage-88%25-green) ![](https://img.shields.io/github/stars/stefanak-michal/Bolt) ![](https://img.shields.io/packagist/dt/stefanak-michal/bolt) ![](https://img.shields.io/github/v/release/stefanak-michal/bolt) ![](https://img.shields.io/github/commits-since/stefanak-michal/bolt/latest)
 
 ## [Version support](https://github.com/stefanak-michal/Bolt/wiki/Version-support)
 ## [Requirements](https://github.com/stefanak-michal/Bolt/wiki/Requirements)

src/protocol/IProtocol.php

@@ -42,8 +42,7 @@ public function discardAll(...$args): bool;
 
     /**
      * Send RESET message
-     * @param mixed ...$args
      */
-    public function reset(...$args): bool;
+    public function reset(): bool;
 
 }

src/protocol/V1.php

@@ -120,11 +120,10 @@ private function ackFailure(): bool
     }
 
     /**
-     * @param mixed ...$args
      * @return bool
      * @throws Exception
      */
-    public function reset(...$args): bool
+    public function reset(): bool
     {
         $this->write($this->packer->pack(0x0F));
         $this->read($signature);

src/protocol/V3.php

@@ -81,11 +81,10 @@ public function run(...$args): array
     }
 
     /**
-     * @param mixed ...$args
      * @return bool
      * @throws Exception
      */
-    public function reset(...$args): bool
+    public function reset(): bool
     {
         $this->write($this->packer->pack(0x0F));
         return true;
@@ -110,11 +109,10 @@ public function begin(...$args): bool
     }
 
     /**
-     * @param mixed ...$args
      * @return bool
      * @throws Exception
      */
-    public function commit(...$args): bool
+    public function commit(): bool
     {
         $this->write($this->packer->pack(0x12));
         $output = $this->read($signature);
@@ -128,11 +126,10 @@ public function commit(...$args): bool
     }
 
     /**
-     * @param mixed ...$args
      * @return bool
      * @throws Exception
      */
-    public function rollback(...$args): bool
+    public function rollback(): bool
     {
         $this->write($this->packer->pack(0x13));
         $output = $this->read($signature);
@@ -146,10 +143,9 @@ public function rollback(...$args): bool
     }
 
     /**
-     * @param mixed ...$args
      * @throws Exception
      */
-    public function goodbye(...$args)
+    public function goodbye()
     {
         $this->write($this->packer->pack(0x02));
     }

tests/BoltTest.php

@@ -17,6 +17,14 @@
  * @covers \Bolt\connection\StreamSocket
  * @covers \Bolt\PackStream\v1\Packer
  * @covers \Bolt\PackStream\v1\Unpacker
+ * @covers \Bolt\protocol\V1
+ * @covers \Bolt\protocol\V2
+ * @covers \Bolt\protocol\V3
+ * @covers \Bolt\protocol\V4
+ * @covers \Bolt\protocol\V4_1
+ * @covers \Bolt\protocol\V4_2
+ * @covers \Bolt\protocol\V4_3
+ * @covers \Bolt\protocol\V4_4
  *
  * @package Bolt\tests
  * @requires PHP >= 7.1
@@ -165,20 +173,18 @@ private function formatParameter(Bolt $bolt, string $name): string
         return self::$parameterType ? ('{' . $name . '}') : ('$' . $name);
     }
 
-
-
     /**
      * @depends testHello
      * @param Bolt $bolt
      */
     public function testRoute(Bolt $bolt): void
     {
         $version = $bolt->getProtocolVersion();
+        $route = $bolt->route();
         if ($version >= 4.3) {
-            $route = $bolt->route();
             self::assertNotEmpty($route);
         } else {
-            self::assertNull($bolt->route());
+            self::assertNull($route);
         }
     }
 }