Merge remote-tracking branch 'origin/master'

Author: stefanak-michal

README.md

@@ -1,34 +1,16 @@
 # Bolt
-Bolt protocol library over TCP socket. Bolt protocol is primary used for communication with [Neo4j](https://neo4j.com/) Graph database. The documentation is available at [https://7687.org/](https://7687.org/).
+Bolt protocol library over TCP socket. Bolt protocol is created and in use for communication with [Neo4j](https://neo4j.com/) Graph database. The documentation is available at [https://7687.org/](https://7687.org/). This library is aimed to be low level and keep up with protocol messages architecture and specifications.
 
 ![](https://img.shields.io/badge/phpunit-passed-success) ![](https://img.shields.io/badge/coverage-86%25-green) ![](https://img.shields.io/github/stars/stefanak-michal/Bolt) ![](https://img.shields.io/packagist/dt/stefanak-michal/bolt) ![](https://img.shields.io/github/v/release/stefanak-michal/bolt) ![](https://img.shields.io/github/commits-since/stefanak-michal/bolt/latest)
 
-## Version support
-Bolt <= 4.1
-
-| Neo4j Version | Bolt 1 | Bolt 2 | Bolt 3 | Bolt 4.0 | Bolt 4.1 |
-|:-------------:|:------:|:------:|:------:|:--------:|:--------:|
-| 3.0           | x      |        |        |          |          |
-| 3.1           | x      |        |        |          |          |
-| 3.2           | x      |        |        |          |          |
-| 3.3           | x      |        |        |          |          |
-| 3.4           | (x)    | x      |        |          |          |
-| 3.5           |        | (x)    | x      |          |          |
-| 4.0           |        |        | (x)    | x        |          |
-| 4.1           |        |        | (x)    | (x)      | x        |
-| 4.2           |        |        | (x)    | (x)      | (x)      |
-
-<sup>The (x) denotes that support could be removed in next version of Neo4j.</sup>
-
+## [Version support](https://github.com/stefanak-michal/Bolt/wiki/Version-support)
 ## [Requirements](https://github.com/stefanak-michal/Bolt/wiki/Requirements)
 ## [Installation](https://github.com/stefanak-michal/Bolt/wiki/Installation)
 ## [Usage](https://github.com/stefanak-michal/Bolt/wiki/Usage)
 ## [Errors](https://github.com/stefanak-michal/Bolt/wiki/Errors)
 
 ## Author note
-I really like Neo4j and I wanted to use it with PHP. But after I looked on official php library, I was really disappointed. Too much dependencies. I don't like if I have to install 10 things because of one. First I decided to use HTTP API for communication, but it wasn't fast enough. I went through bolt protocol documentation and I said to myself, why not to create own simpler library?
-
-[Speed comparison](https://github.com/stefanak-michal/Bolt/wiki/Speed-comparison)
+Bolt protocol is created by Neo4j and I heard about it first time at 2012 (maybe 2013). I was looking for a opportunity to use their database and that opportunity came after few years. From that moment I love this database. But there was small catch, they had low support for combination Bolt protocol and PHP. Official existing library for this language is outdated and repository is archived. Of course Neo4j has API access, but I feel the cURL in PHP is slower then direct socket connection. I've decided to make my own library for their Bolt protocol.
 
 ## Another solutions
 https://neo4j.com/developer/php/

composer.json

@@ -28,7 +28,8 @@
     "authors": [
         {
             "name": "Michal Stefanak",
-            "role": "Developer"
+            "role": "Developer",
+            "homepage": "https://www.linkedin.com/in/michalstefanak/"
         }
     ],
     "autoload": {

src/connection/Socket.php

@@ -16,9 +16,9 @@ class Socket extends AConnection
 {
 
     /**
-     * @var resource
+     * @var resource|object|bool
      */
-    private $socket;
+    private $socket = false;
 
     /**
      * Create socket connection
@@ -32,7 +32,7 @@ public function connect(): bool
         }
 
         $this->socket = @socket_create(AF_INET, SOCK_STREAM, SOL_TCP);
-        if (!is_resource($this->socket)) {
+        if ($this->socket === false) {
             throw new ConnectException('Cannot create socket');
         }
 
@@ -61,7 +61,7 @@ public function connect(): bool
      */
     public function write(string $buffer)
     {
-        if (!is_resource($this->socket)) {
+        if ($this->socket === false) {
             throw new ConnectException('Not initialized socket');
         }
 
@@ -93,7 +93,7 @@ public function read(int $length = 2048): string
     {
         $output = '';
 
-        if (!is_resource($this->socket)) {
+        if ($this->socket === false) {
             throw new ConnectException('Not initialized socket');
         }
 
@@ -117,7 +117,7 @@ public function read(int $length = 2048): string
      */
     public function disconnect()
     {
-        if (is_resource($this->socket)) {
+        if ($this->socket !== false) {
             @socket_shutdown($this->socket);
             @socket_close($this->socket);
         }

tests/ATest.php

@@ -3,7 +3,7 @@
 namespace Bolt\tests;
 
 use PHPUnit\Framework\TestCase;
-use Bolt\connection\IConnection;
+use Bolt\connection\AConnection;
 
 /**
  * Class ATest
@@ -33,15 +33,15 @@ abstract class ATest extends TestCase
 
     /**
      * Mock Socket class with "write" and "read" methods
-     * @return IConnection
+     * @return AConnection
      */
     protected function mockConnection()
     {
         $mockBuilder = $this
-            ->getMockBuilder(IConnection::class)
+            ->getMockBuilder(AConnection::class)
             ->disableOriginalConstructor();
         call_user_func([$mockBuilder, method_exists($mockBuilder, 'onlyMethods') ? 'onlyMethods' : 'setMethods'], ['__construct', 'write', 'read', 'connect', 'disconnect']);
-        /** @var IConnection $connection */
+        /** @var AConnection $connection */
         $connection = $mockBuilder->getMock();
 
         $connection
@@ -98,9 +98,9 @@ public function readCallback(): string
     }
 
     /**
-     * Reset mockup IConnetion variables
+     * Reset mockup AConnetion variables
      */
-    protected function setUp()
+    protected function setUp(): void
     {
         self::$readIndex = 0;
         self::$readArray = [];