created tests for both sockets

Author: transistive

src/connection/Socket.php

@@ -128,9 +128,6 @@ public function setTimeout(float $timeout): void
         $this->configureTimeout();
     }
 
-    /**
-     * @return void
-     */
     private function configureTimeout(): void
     {
         $timeoutSeconds = floor($this->timeout);

tests/connection/StreamSocketTest.php renamed to tests/connection/AConnectionTest.php

@@ -3,25 +3,34 @@
 namespace Bolt\tests\connection;
 
 use Bolt\Bolt;
+use Bolt\connection\IConnection;
+use Bolt\connection\Socket;
 use Bolt\connection\StreamSocket;
 use Bolt\error\ConnectException;
 use Bolt\error\MessageException;
 use Bolt\helpers\Auth;
 use Bolt\protocol\V4;
-use Exception;
 use PHPUnit\Framework\TestCase;
 use function microtime;
 
-final class StreamSocketTest extends TestCase
+final class AConnectionTest extends TestCase
 {
+    public function provideConnections(): array
+    {
+        return [
+            [StreamSocket::class],
+            [Socket::class],
+        ];
+    }
+
     /**
-     * @throws Exception
+     * @dataProvider provideConnections
      */
-    public function testMillisecondTimeout(): void
+    public function testMillisecondTimeout(string $alias): void
     {
-        $socket = new StreamSocket($GLOBALS['NEO_HOST'] ?? '127.0.0.1', (int) ($GLOBALS['NEO_PORT'] ?? 7687), 1.5);
-        $bolt = new Bolt($socket);
-        $protocol = $bolt->build();
+        $socket = $this->getConnection($alias);
+        $protocol = (new Bolt($socket))->build();
+        $socket->setTimeout(1.5);
         $protocol->init(Auth::basic($GLOBALS['NEO_USER'], $GLOBALS['NEO_PASS']));
 
         $time = microtime(true);
@@ -39,13 +48,12 @@ public function testMillisecondTimeout(): void
     }
 
     /**
-     * @throws Exception
+     * @dataProvider provideConnections
      */
-    public function testSecondsTimeout(): void
+    public function testSecondsTimeout(string $alias): void
     {
-        $socket = new StreamSocket($GLOBALS['NEO_HOST'] ?? '127.0.0.1', (int) ($GLOBALS['NEO_PORT'] ?? 7687), 1);
-        $bolt = new Bolt($socket);
-        $protocol = $bolt->build();
+        $socket = $this->getConnection($alias);
+        $protocol = (new Bolt($socket))->build();
         $protocol->init(Auth::basic($GLOBALS['NEO_USER'], $GLOBALS['NEO_PASS']));
 
         $time = microtime(true);
@@ -61,8 +69,12 @@ public function testSecondsTimeout(): void
         }
     }
 
-    public function testTimeoutRecoverAndReset(): void
+    /**
+     * @dataProvider provideConnections
+     */
+    public function testTimeoutRecoverAndReset(string $alias): void
     {
+        $socket = $this->getConnection($alias);
         $streamSocket = new StreamSocket($GLOBALS['NEO_HOST'] ?? '127.0.0.1', (int) ($GLOBALS['NEO_PORT'] ?? 7687), 1);
         /** @var V4 $protocol */
         $protocol = (new Bolt($streamSocket))->build();
@@ -104,4 +116,9 @@ public function testTimeoutRecoverAndReset(): void
             $this->assertEqualsWithDelta(1.0, $newTime - $time, 0.2);
         }
     }
+
+    private function getConnection(string $class): IConnection
+    {
+        return new $class($GLOBALS['NEO_HOST'] ?? '127.0.0.1', (int) ($GLOBALS['NEO_PORT'] ?? 7687), 1);
+    }
 }