Merge pull request #52 from neo4j-php/issue_51/chunking

Changed return of pack to Generator. Added chunking for write.

Author: stefanak-michal

src/PackStream/IPacker.php

@@ -2,6 +2,8 @@
 
 namespace Bolt\PackStream;
 
+use Generator;
+
 /**
  * Interface IPacker
  *
@@ -14,7 +16,7 @@ interface IPacker
     /**
      * @param $signature
      * @param mixed ...$params
-     * @return string
+     * @return Generator
      */
-    public function pack($signature, ...$params): string;
+    public function pack($signature, ...$params): Generator;
 }

src/PackStream/v1/Packer.php

@@ -4,6 +4,7 @@
 
 use Bolt\PackStream\IPacker;
 use Bolt\error\PackException;
+use Generator;
 
 /**
  * Class Packer of PackStream version 1
@@ -23,10 +24,10 @@ class Packer implements IPacker
      * Pack message with parameters
      * @param $signature
      * @param mixed ...$params
-     * @return string
+     * @return Generator
      * @throws PackException
      */
-    public function pack($signature, ...$params): string
+    public function pack($signature, ...$params): Generator
     {
         $output = '';
 
@@ -49,7 +50,13 @@ public function pack($signature, ...$params): string
         }
 
         //structure buffer
-        return pack('n', mb_strlen($output, '8bit')) . $output . chr(0x00) . chr(0x00);
+        $len = mb_strlen($output, 'UTF-8');
+        for ($i = 0; $i < $len; $i += 65535) {
+            $chunk = mb_substr($output, $i, 65535, '8bit');
+            yield pack('n', mb_strlen($chunk, '8bit')) . $chunk;
+        }
+
+        yield chr(0x00) . chr(0x00);
     }
 
     /**

src/protocol/AProtocol.php

@@ -2,7 +2,7 @@
 
 namespace Bolt\protocol;
 
-use Bolt\Bolt;
+use Generator;
 use Bolt\PackStream\{IPacker, IUnpacker};
 use Bolt\connection\IConnection;
 use Exception;
@@ -72,12 +72,13 @@ public function goodbye(...$args)
 
     /**
      * Write to connection
-     * @param string $buffer
+     * @param Generator $generator
      * @throws Exception
      */
-    protected function write(string $buffer)
+    protected function write(Generator $generator)
     {
-        $this->connection->write($buffer);
+        foreach ($generator as $buffer)
+            $this->connection->write($buffer);
     }
 
     /**