optimized for better performance. refactored unpacking first structure and access to signature.

Author: stefanak-michal

src/PackStream/IUnpacker.php

@@ -12,9 +12,15 @@
 interface IUnpacker
 {
     /**
+     * Unpack message
      * @param string $msg
-     * @param int $signature
      * @return mixed
      */
-    public function unpack(string $msg, int &$signature);
+    public function unpack(string $msg);
+
+    /**
+     * Get unpacked message status signature
+     * @return int
+     */
+    public function getSignature(): int;
 }

src/PackStream/v1/Packer.php

@@ -33,6 +33,11 @@ class Packer implements IPacker
     private const LARGE = 65536;
     private const HUGE = 4294967295;
 
+    /**
+     * @var bool
+     */
+    private $littleEndian;
+
     private $structuresLt = [
         Relationship::class => [0x52, 'id' => 'packInteger', 'startNodeId' => 'packInteger', 'endNodeId' => 'packInteger', 'type' => 'packString', 'properties' => 'packMap'],
         Date::class => [0x44, 'days' => 'packInteger'],
@@ -57,6 +62,8 @@ public function pack($signature, ...$params): Generator
     {
         $output = '';
 
+        $this->littleEndian = unpack('S', "\x01\x00")[1] === 1;
+
         //structure
         $length = count($params);
         if ($length < self::SMALL) { //TINY_STRUCT
@@ -163,27 +170,25 @@ private function packFloat(float $value): string
     private function packInteger(int $value): string
     {
         $output = '';
-        $tmp = unpack('S', "\x01\x00");
-        $little = $tmp[1] == 1;
 
         if ($value >= 0 && $value <= 127) { //+TINY_INT
             $packed = pack('C', 0b00000000 | $value);
-            $output .= $little ? strrev($packed) : $packed;
+            $output .= $this->littleEndian ? strrev($packed) : $packed;
         } elseif ($value >= -16 && $value < 0) { //-TINY_INT
             $packed = pack('c', 0b11110000 | $value);
-            $output .= $little ? strrev($packed) : $packed;
+            $output .= $this->littleEndian ? strrev($packed) : $packed;
         } elseif ($value >= -128 && $value <= -17) { //INT_8
             $packed = pack('c', $value);
-            $output .= chr(0xC8) . ($little ? strrev($packed) : $packed);
+            $output .= chr(0xC8) . ($this->littleEndian ? strrev($packed) : $packed);
         } elseif (($value >= 128 && $value <= 32767) || ($value >= -32768 && $value <= -129)) { //INT_16
             $packed = pack('s', $value);
-            $output .= chr(0xC9) . ($little ? strrev($packed) : $packed);
+            $output .= chr(0xC9) . ($this->littleEndian ? strrev($packed) : $packed);
         } elseif (($value >= 32768 && $value <= 2147483647) || ($value >= -2147483648 && $value <= -32769)) { //INT_32
             $packed = pack('l', $value);
-            $output .= chr(0xCA) . ($little ? strrev($packed) : $packed);
+            $output .= chr(0xCA) . ($this->littleEndian ? strrev($packed) : $packed);
         } elseif (($value >= 2147483648 && $value <= 9223372036854775807) || ($value >= -9223372036854775808 && $value <= -2147483649)) { //INT_64
             $packed = pack('q', $value);
-            $output .= chr(0xCB) . ($little ? strrev($packed) : $packed);
+            $output .= chr(0xCB) . ($this->littleEndian ? strrev($packed) : $packed);
         } else {
             throw new PackException('Integer out of range');
         }