Updating on theme changes.

Author: stefanceriu

README.md

@@ -21,7 +21,6 @@ SCXcodeMiniMap is a plugin that adds a source editor MiniMap to Xcode.
 
 ##Known issues
 - Line breaks don't match between the normal editor and the minimap
-- It doesn't update automatically on theme changes (switching between sources fixes it) 
 
 ## License
 SCXcodeMiniMap is released under the GNU GENERAL PUBLIC LICENSE (see the LICENSE file)

SCXcodeMinimap/SCMiniMapView.m

@@ -9,6 +9,8 @@
 #import "SCMiniMapView.h"
 #import "SCXcodeMinimap.h"
 
+static NSString * const DVTFontAndColorSourceTextSettingsChangedNotification = @"DVTFontAndColorSourceTextSettingsChangedNotification";
+
 @implementation SCMiniMapView
 
 - (id)initWithFrame:(NSRect)frame
@@ -33,6 +35,11 @@ - (id)initWithFrame:(NSRect)frame
                                                  selector:@selector(hide)
                                                      name:SCXodeMinimapWantsToBeHiddenNotification
                                                    object:nil];
+        
+        [[NSNotificationCenter defaultCenter] addObserver:self
+                                                 selector:@selector(updateTheme)
+                                                     name:DVTFontAndColorSourceTextSettingsChangedNotification
+                                                   object:nil];
     }
     return self;
 }
@@ -75,18 +82,7 @@ - (NSTextView *)textView
 
         [self setDocumentView:_textView];
 
-        NSColor *miniMapBackgroundColor = [NSColor clearColor];
-        Class DVTFontAndColorThemeClass = NSClassFromString(@"DVTFontAndColorTheme");
-        
-        if([DVTFontAndColorThemeClass respondsToSelector:@selector(currentTheme)]) {
-            
-            NSObject *theme = [DVTFontAndColorThemeClass performSelector:@selector(currentTheme)];
-            if([theme respondsToSelector:@selector(sourceTextBackgroundColor)]) {
-                miniMapBackgroundColor = [theme performSelector:@selector(sourceTextBackgroundColor)];
-            }
-        }
-        
-        [_textView setBackgroundColor:[miniMapBackgroundColor shadowWithLevel:kDefaultShadowLevel]];
+        [self updateTheme];
     }
 
     return _textView;
@@ -129,6 +125,23 @@ - (void)hide
 
 #pragma mark - Updating
 
+- (void)updateTheme
+{
+    NSColor *miniMapBackgroundColor = [NSColor clearColor];
+    Class DVTFontAndColorThemeClass = NSClassFromString(@"DVTFontAndColorTheme");
+    
+    if([DVTFontAndColorThemeClass respondsToSelector:@selector(currentTheme)]) {
+        
+        NSObject *theme = [DVTFontAndColorThemeClass performSelector:@selector(currentTheme)];
+        if([theme respondsToSelector:@selector(sourceTextBackgroundColor)]) {
+            miniMapBackgroundColor = [theme performSelector:@selector(sourceTextBackgroundColor)];
+        }
+    }
+    
+    [self.textView setBackgroundColor:[miniMapBackgroundColor shadowWithLevel:kDefaultShadowLevel]];
+    [self.selectionView setNeedsDisplay:YES];
+}
+
 - (void)updateTextView
 {
     if ([self isHidden]) {

SCXcodeMinimap/SCSelectionView.m

@@ -28,6 +28,14 @@ - (void)drawRect:(NSRect)dirtyRect
     NSRectFill(dirtyRect);
 }
 
+- (void)setNeedsDisplay:(BOOL)flag
+{
+    if(self.needsDisplay == flag) return;
+    
+    [self setSelectionColor:nil];
+    [super setNeedsDisplay:flag];
+}
+
 - (NSColor *)selectionColor
 {
     if(_selectionColor == nil) {

SCXcodeMinimap/SCXcodeMinimap.m

@@ -15,12 +15,11 @@
 static NSString * const IDESourceCodeEditorDidFinishSetupNotification = @"IDESourceCodeEditorDidFinishSetup";
 static NSString * const IDEEditorDocumentDidChangeNotification = @"IDEEditorDocumentDidChangeNotification";
 static NSString * const IDESourceCodeEditorTextViewBoundsDidChangeNotification = @"IDESourceCodeEditorTextViewBoundsDidChangeNotification";
-static NSString * const DVTFontAndColorSourceTextSettingsChangedNotification = @"DVTFontAndColorSourceTextSettingsChangedNotification";//Unused
 
-NSString *const SCXodeMinimapWantsToBeShownNotification = @"SCXodeMinimapWantsToBeShownNotification";
-NSString *const SCXodeMinimapWantsToBeHiddenNotification = @"SCXodeMinimapWantsToBeHiddenNotification";
+NSString * const SCXodeMinimapWantsToBeShownNotification = @"SCXodeMinimapWantsToBeShownNotification";
+NSString * const SCXodeMinimapWantsToBeHiddenNotification = @"SCXodeMinimapWantsToBeHiddenNotification";
 
-NSString *const SCXodeMinimapIsInitiallyHidden  = @"SCXodeMinimapIsInitiallyHidden";
+NSString * const SCXodeMinimapIsInitiallyHidden  = @"SCXodeMinimapIsInitiallyHidden";
 
 @implementation SCXcodeMinimap