Skip to content

Commit 3df3f7d

Browse files
authored
Merge pull request #263 from azizhk/amd_auto
Auto Bundles were not working in AMD Environment
2 parents f1ebe35 + de375ce commit 3df3f7d

File tree

6 files changed

+38
-33
lines changed

6 files changed

+38
-33
lines changed

Brocfile.js

Lines changed: 28 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -33,20 +33,25 @@ var es5 = new Babel(lib, {
3333
blacklist: ['es6.modules']
3434
});
3535

36+
function rollupConfig(entry) {
37+
return new Rollup(es5, {
38+
rollup: {
39+
entry: 'lib/' + entry,
40+
targets: [
41+
{
42+
format: 'umd',
43+
moduleName: 'ES6Promise',
44+
dest: entry,
45+
sourceMap: 'inline'
46+
}
47+
]
48+
}
49+
});
50+
}
51+
3652
// build RSVP itself
37-
var es6Promise = new Rollup(es5, {
38-
rollup: {
39-
entry: 'lib/es6-promise.js',
40-
targets: [
41-
{
42-
format: 'umd',
43-
moduleName: 'ES6Promise',
44-
dest: 'es6-promise.js',
45-
sourceMap: 'inline'
46-
}
47-
]
48-
}
49-
});
53+
var es6Promise = rollupConfig('es6-promise.js')
54+
var es6PromiseAuto = rollupConfig('es6-promise.auto.js')
5055

5156
var testBundle = watchify(merge([
5257
mv(es6Promise, 'test'),
@@ -59,45 +64,42 @@ var header = stew.map(find('config/versionTemplate.txt'), function(content) {
5964
return content.replace(/VERSION_PLACEHOLDER_STRING/, version());
6065
});
6166

62-
var dist = es6Promise;
63-
64-
function concatAs(tree, outputFile) {
67+
function concatAs(outputFile) {
6568
return merge([
66-
concat(merge([tree, header]), {
69+
concat(merge([es6Promise, header]), {
6770
headerFiles: ['config/versionTemplate.txt'],
6871
inputFiles: ['es6-promise.js'],
6972
outputFile: outputFile
7073
}),
7174

72-
concat(merge([tree, header]), {
75+
concat(merge([es6PromiseAuto, header]), {
7376
headerFiles: ['config/versionTemplate.txt'],
74-
inputFiles: ['es6-promise.js'],
77+
inputFiles: ['es6-promise.auto.js'],
7578
outputFile: outputFile.replace('es6-promise', 'es6-promise.auto'),
76-
footer: 'ES6Promise.polyfill();',
7779
}),
7880

7981
]);
8082
}
8183

82-
function production(dist, header) {
84+
function production() {
8385
var result;
8486
env('production', function(){
85-
result = uglify(concatAs(dist, 'es6-promise.min.js'), {
87+
result = uglify(concatAs('es6-promise.min.js'), {
8688
compress: true,
8789
mangle: true,
8890
});
8991
})
9092
return result;
9193
}
9294

93-
function development(dist, header) {
94-
return concatAs(dist, 'es6-promise.js');
95+
function development() {
96+
return concatAs('es6-promise.js');
9597
}
9698

9799
module.exports = merge([
98100
merge([
99-
production(es6Promise, header),
100-
development(es6Promise, header),
101+
production(),
102+
development(),
101103
].filter(Boolean)),
102104
// test stuff
103105
testFiles,

dist/es6-promise.auto.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/es6-promise.auto.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/es6-promise.auto.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/es6-promise.auto.min.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/es6-promise.auto.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import Promise from './es6-promise';
2+
Promise.polyfill();
3+
export default Promise;

0 commit comments

Comments
 (0)