Skip to content

Commit e0e1a03

Browse files
committed
Auto Bundles were not working in AMD Environment
1 parent f5f44e8 commit e0e1a03

File tree

7 files changed

+66
-39
lines changed

7 files changed

+66
-39
lines changed

Brocfile.js

Lines changed: 29 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -33,20 +33,26 @@ var es5 = new Babel(lib, {
3333
blacklist: ['es6.modules']
3434
});
3535

36+
function rollupConfig(entry) {
37+
return new Rollup(es5, {
38+
rollup: {
39+
entry: 'lib/' + entry,
40+
cache: 'BUILD:es6-promise',
41+
targets: [
42+
{
43+
format: 'umd',
44+
moduleName: 'ES6Promise',
45+
dest: entry,
46+
sourceMap: 'inline'
47+
}
48+
]
49+
}
50+
});
51+
}
52+
3653
// build RSVP itself
37-
var es6Promise = new Rollup(es5, {
38-
rollup: {
39-
entry: 'lib/es6-promise.js',
40-
targets: [
41-
{
42-
format: 'umd',
43-
moduleName: 'ES6Promise',
44-
dest: 'es6-promise.js',
45-
sourceMap: 'inline'
46-
}
47-
]
48-
}
49-
});
54+
var es6Promise = rollupConfig('es6-promise.js')
55+
var es6PromiseAuto = rollupConfig('es6-promise.auto.js')
5056

5157
var testBundle = watchify(merge([
5258
mv(es6Promise, 'test'),
@@ -59,45 +65,42 @@ var header = stew.map(find('config/versionTemplate.txt'), function(content) {
5965
return content.replace(/VERSION_PLACEHOLDER_STRING/, version());
6066
});
6167

62-
var dist = es6Promise;
63-
64-
function concatAs(tree, outputFile) {
68+
function concatAs(outputFile) {
6569
return merge([
66-
concat(merge([tree, header]), {
70+
concat(merge([es6Promise, header]), {
6771
headerFiles: ['config/versionTemplate.txt'],
6872
inputFiles: ['es6-promise.js'],
6973
outputFile: outputFile
7074
}),
7175

72-
concat(merge([tree, header]), {
76+
concat(merge([es6PromiseAuto, header]), {
7377
headerFiles: ['config/versionTemplate.txt'],
74-
inputFiles: ['es6-promise.js'],
78+
inputFiles: ['es6-promise.auto.js'],
7579
outputFile: outputFile.replace('es6-promise', 'es6-promise.auto'),
76-
footer: 'ES6Promise.polyfill();',
7780
}),
7881

7982
]);
8083
}
8184

82-
function production(dist, header) {
85+
function production() {
8386
var result;
8487
env('production', function(){
85-
result = uglify(concatAs(dist, 'es6-promise.min.js'), {
88+
result = uglify(concatAs('es6-promise.min.js'), {
8689
compress: true,
8790
mangle: true,
8891
});
8992
})
9093
return result;
9194
}
9295

93-
function development(dist, header) {
94-
return concatAs(dist, 'es6-promise.js');
96+
function development() {
97+
return concatAs('es6-promise.js');
9598
}
9699

97100
module.exports = merge([
98101
merge([
99-
production(es6Promise, header),
100-
development(es6Promise, header),
102+
production(),
103+
development(),
101104
].filter(Boolean)),
102105
// test stuff
103106
testFiles,

dist/es6-promise.auto.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/es6-promise.auto.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/es6-promise.auto.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/es6-promise.auto.min.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/es6-promise.auto.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import Promise from './es6-promise';
2+
Promise.polyfill();
3+
export default Promise;

yarn.lock

Lines changed: 27 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,7 @@ broccoli-clean-css@^1.1.0:
512512
inline-source-map-comment "^1.0.5"
513513
json-stable-stringify "^1.0.0"
514514

515-
broccoli-concat@^3.0.2, broccoli-concat@^3.0.4:
515+
broccoli-concat@^3.0.4:
516516
version "3.0.5"
517517
resolved "https://registry.npmjs.org/broccoli-concat/-/broccoli-concat-3.0.5.tgz#306fb47e7caa23ec726391fe8b584765946eb52e"
518518
dependencies:
@@ -526,6 +526,23 @@ broccoli-concat@^3.0.2, broccoli-concat@^3.0.4:
526526
lodash.uniq "^4.2.0"
527527
mkdirp "^0.5.1"
528528

529+
broccoli-concat@^3.1.0:
530+
version "3.2.2"
531+
resolved "https://registry.yarnpkg.com/broccoli-concat/-/broccoli-concat-3.2.2.tgz#86ffdc52606eb590ba9f6b894c5ec7a016f5b7b9"
532+
dependencies:
533+
broccoli-kitchen-sink-helpers "^0.3.1"
534+
broccoli-plugin "^1.3.0"
535+
broccoli-stew "^1.3.3"
536+
ensure-posix-path "^1.0.2"
537+
fast-sourcemap-concat "^1.0.1"
538+
find-index "^1.1.0"
539+
fs-extra "^1.0.0"
540+
fs-tree-diff "^0.5.6"
541+
lodash.merge "^4.3.0"
542+
lodash.omit "^4.1.0"
543+
lodash.uniq "^4.2.0"
544+
walk-sync "^0.3.1"
545+
529546
broccoli-config-loader@^1.0.0:
530547
version "1.0.0"
531548
resolved "https://registry.npmjs.org/broccoli-config-loader/-/broccoli-config-loader-1.0.0.tgz#c3cf5ecfaffc04338c6f1d5d38dc36baeaa131ba"
@@ -1998,6 +2015,10 @@ [email protected]:
19982015
statuses "~1.3.0"
19992016
unpipe "~1.0.0"
20002017

2018+
find-index@^1.1.0:
2019+
version "1.1.0"
2020+
resolved "https://registry.yarnpkg.com/find-index/-/find-index-1.1.0.tgz#53007c79cd30040d6816d79458e8837d5c5705ef"
2021+
20012022
find-up@^2.1.0:
20022023
version "2.1.0"
20032024
resolved "https://registry.npmjs.org/find-up/-/find-up-2.1.0.tgz#45d1b7e506c717ddd482775a2b77920a3c0c57a7"
@@ -2189,7 +2210,7 @@ [email protected]:
21892210
inherits "2"
21902211
minimatch "~0.2.11"
21912212

2192-
[email protected], glob@^7.0.5:
2213+
21932214
version "7.0.5"
21942215
resolved "https://registry.npmjs.org/glob/-/glob-7.0.5.tgz#b4202a69099bbb4d292a7c1b95b6682b67ebdc95"
21952216
dependencies:
@@ -2200,7 +2221,7 @@ [email protected], glob@^7.0.5:
22002221
once "^1.3.0"
22012222
path-is-absolute "^1.0.0"
22022223

2203-
[email protected], glob@^7.0.0, glob@^7.0.4, glob@^7.1.0:
2224+
[email protected], glob@^7.0.0, glob@^7.0.4, glob@^7.0.5, glob@^7.1.0:
22042225
version "7.1.1"
22052226
resolved "https://registry.npmjs.org/glob/-/glob-7.1.1.tgz#805211df04faaf1c63a3600306cdf5ade50b2ec8"
22062227
dependencies:
@@ -3819,9 +3840,9 @@ regjsparser@^0.1.4:
38193840
dependencies:
38203841
jsesc "~0.5.0"
38213842

3822-
3823-
version "2.5.3"
3824-
resolved "https://registry.npmjs.org/release-it/-/release-it-2.5.3.tgz#653da644c83cf9eebab8cbdc5384222e37b303e0"
3843+
3844+
version "2.5.4"
3845+
resolved "https://registry.yarnpkg.com/release-it/-/release-it-2.5.4.tgz#b85fc43d424aa19ee4cc7265936385f2095a5e50"
38253846
dependencies:
38263847
chalk "1.1.3"
38273848
github "7.2.0"

0 commit comments

Comments
 (0)