make injection use helm

Author: therealmitchconnors

.github/workflows/analyze.yaml

@@ -30,4 +30,5 @@ jobs:
         run: |
           istioctl analyze -A --use-kube=false \
             --failure-threshold ERROR \
-            $(find . -not -path "*/.git*/*" -not -path "*/clusters/*" -name "*.yaml" -type f)
+            $(find . -not -path "*/.git*/*" -not -path "*/clusters/*" \
+              -not -name "*.patch.yaml" -not -name "kustomization.yaml" -name "*.yaml" -type f)

.github/workflows/inject-sidecar.yaml

@@ -25,6 +25,8 @@ jobs:
         uses: istio/[email protected]
         with:
           version: ${{ env.ISTIO_VERSION }}
+      - uses: azure/setup-helm@v1
+        id: install
       - name: Get Istioctl
         run: |
           istioctl version --remote=false
@@ -36,14 +38,14 @@ jobs:
         id: inject
         run: |
           # hydrate isto manifest into configmap files
-          istioctl manifest generate \
-            -f istio/system/profile.yaml > manifests.yaml
-          echo "first yq"
-          cat manifests.yaml | yq e '. | select(.kind == "ConfigMap" and .metadata.name =="istio-sidecar-injector") | .data.config' - > injector.yaml
-          echo "second yq"
-          cat manifests.yaml | yq e '. | select(.kind == "ConfigMap" and .metadata.name =="istio-sidecar-injector") | .data.values' - > values.yaml
-          echo "third yq"
-          cat manifests.yaml | yq e '. | select(.kind == "ConfigMap" and .metadata.name =="istio") | .data.mesh' - > mesh.yaml
+
+          URI=$(cat istio/system/istio.yaml | yq e '. | select(.kind == "HelmRepository" and .metadata.name =="istio") | .spec.url' -)
+          cat istio/system/istio.yaml | yq e '. | select(.kind == "HelmRelease" and .metadata.name =="istiod") | .spec.values' - > values.yaml
+          VERSION=$(cat clusters/my-cluster/istio-version.yaml | yq e '.data.version' -)
+          helm repo add istio $URI
+          helm template -f values.yaml --version $VERSION istiod istio/istiod | yq e '.| select(.kind == "ConfigMap" and .metadata.name == "istio-sidecar-injector") | .data.config' - > injector.yaml
+          helm template -f values.yaml --version $VERSION istiod istio/istiod | yq e '.| select(.kind == "ConfigMap" and .metadata.name == "istio") | .data.mesh' - > mesh.yaml
+          helm template -f values.yaml --version $VERSION istiod istio/istiod | yq e '.| select(.kind == "ConfigMap" and .metadata.name == "istio-sidecar-injector") | .data.values' - > inj-values.yaml
 
           python -m pip install jsonpatch
 
@@ -55,7 +57,7 @@ jobs:
             istioctl kube-inject \
                                --injectConfigFile injector.yaml \
                                 --meshConfigFile mesh.yaml \
-                                --valuesFile values.yaml \
+                                --valuesFile inj-values.yaml \
                                -f $1 -o $NAME.gen.$EXTENSION
 
             # injected yaml ends with '---', so remove before converting to json