Use get-istioctl action in the analyze workflow

Signed-off-by: Stefan Prodan <[email protected]>

Author: stefanprodan

.github/workflows/analyze-istio.yaml

@@ -11,23 +11,23 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v2
-      - name: Get Istioctl
+      - name: get istio version
+        id: get-istio-version
         run: |
-          ISTIO_VERSION=$(yq eval '. | select(.kind == "Deployment") | .spec.template.spec.containers[0].image | split(":") | .[1]' ./istio/operator/manifests.yaml)
+          ISTIO_VERSION=$(yq eval '.data.version' ./clusters/my-cluster/istio-version.yaml)
           echo "ISTIO_VERSION=$ISTIO_VERSION" >> $GITHUB_ENV
-          # downloadIstio will now retrieve the currently installed binary, instead of latest
-          echo "Downloading Istio (v${ISTIO_VERSION})"
-          curl -sL https://istio.io/downloadIstio | ISTIO_VERSION=$ISTIO_VERSION sh -
+      - name: get istioctl uri
+        id: get-istioctl
+        uses: istio/get-istioctl@e9b2b82bc1cecf150ec6aee77ceee8c256f4faf4
+        with:
+          version: ${{ env.ISTIO_VERSION }}
+      - name: Get Istioctl
+        run: |
+          curl -o istioctl.tar.gz -fsLO ${{ steps.get-istioctl.outputs.istioctl-url }}
+          tar -xzf istioctl.tar.gz
+          ./istioctl version --remote=false
       - name: Istioctl Analyze
         run: |
-          # this command will exit(1) if an error is found in any yaml
-          # istio/operator/manifests.yaml contains an empty yaml doc, which
-          # throws off analyze, so pass it in separately
-          MANIFESTS=$(yq eval '. | select(. | has("kind"))' ./istio/operator/manifests.yaml)
-
-          ISTIO_VERSION=${{ env.ISTIO_VERSION }}
-
-          ./istio-${ISTIO_VERSION}/bin/istioctl analyze -A --use-kube=false \
-            --failure-threshold ERROR $(find . -not -path "*/istio-$ISTIO_VERSION/*" \
-            -not -path "*/.git*/*" -not -path "*/clusters/*" -name "*.yaml" \
-            -not -path "*/istio/operator/manifests.yaml" -type f) -<<<"$MANIFESTS"
+          ./istioctl analyze -A --use-kube=false \
+            --failure-threshold ERROR \
+            $(find . -not -path "*/.git*/*" -not -path "*/clusters/*" -name "*.yaml" -type f)