Skip to content

Commit 6c80136

Browse files
Fix logic assertions
1 parent 7d9b04a commit 6c80136

File tree

2 files changed

+8
-16
lines changed

2 files changed

+8
-16
lines changed

features/logic.feature

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,12 +80,12 @@ Scenario: AND/short_circuit_error_right
8080
Scenario: AND/error_right
8181

8282
When CEL expression 'true && 1/0 != 0' is evaluated
83-
Then eval_error is 'no matching overload'
83+
Then value is celpy.celtypes.BoolType(source=True)
8484

8585
Scenario: AND/error_left
8686

8787
When CEL expression '1/0 != 0 && true' is evaluated
88-
Then eval_error is 'no matching overload'
88+
Then value is celpy.celtypes.BoolType(source=True)
8989

9090
Scenario: AND/no_overload
9191

@@ -141,12 +141,12 @@ Scenario: OR/short_circuit_error_right
141141
Scenario: OR/error_right
142142

143143
When CEL expression 'false || 1/0 != 0' is evaluated
144-
Then eval_error is 'no matching overload'
144+
Then value is celpy.celtypes.BoolType(source=True)
145145

146146
Scenario: OR/error_left
147147

148148
When CEL expression '1/0 != 0 || false' is evaluated
149-
Then eval_error is 'no matching overload'
149+
Then value is celpy.celtypes.BoolType(source=True)
150150

151151
Scenario: OR/no_overload
152152

features/logic.textproto

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -86,16 +86,12 @@ section {
8686
test {
8787
name: "error_right"
8888
expr: "true && 1/0 != 0"
89-
eval_error: {
90-
errors: { message: "no matching overload" }
91-
}
89+
value: { bool_value: true }
9290
}
9391
test {
9492
name: "error_left"
9593
expr: "1/0 != 0 && true"
96-
eval_error: {
97-
errors: { message: "no matching overload" }
98-
}
94+
value: { bool_value: true }
9995
}
10096
test {
10197
name: "no_overload"
@@ -154,16 +150,12 @@ section {
154150
test {
155151
name: "error_right"
156152
expr: "false || 1/0 != 0"
157-
eval_error: {
158-
errors: { message: "no matching overload" }
159-
}
153+
value: { bool_value: true }
160154
}
161155
test {
162156
name: "error_left"
163157
expr: "1/0 != 0 || false"
164-
eval_error: {
165-
errors: { message: "no matching overload" }
166-
}
158+
value: { bool_value: true }
167159
}
168160
test {
169161
name: "no_overload"

0 commit comments

Comments
 (0)