Run Tests on PHP 8.4 (#55)

Author: stefanzweifel

.github/workflows/run-tests.yml

@@ -9,7 +9,7 @@ jobs:
       fail-fast: true
       matrix:
         os: [ubuntu-latest]
-        php: [8.2, 8.3]
+        php: [8.2, 8.3, 8.4]
 
     name: P${{ matrix.php }} - ${{ matrix.os }}
 

app/Actions/AddReleaseNotesToChangelogAction.php

@@ -20,8 +20,7 @@ public function __construct(
         private readonly FindSecondLevelHeadingWithText $findSecondLevelHeadingWithText,
         private readonly PlaceReleaseNotesBelowUnreleasedHeadingAction $addNewReleaseNotesWithUnreleasedHeadingToChangelog,
         private readonly PlaceReleaseNotesAtTheTopAction $addNewReleaseToChangelog
-    ) {
-    }
+    ) {}
 
     /**
      * @throws Throwable

app/Actions/ExtractPermalinkFragmentFromHeadingAction.php

@@ -18,9 +18,7 @@
 
 class ExtractPermalinkFragmentFromHeadingAction
 {
-    public function __construct(private readonly GitHubActionsOutput $gitHubActionsOutput)
-    {
-    }
+    public function __construct(private readonly GitHubActionsOutput $gitHubActionsOutput) {}
 
     public function execute(Heading $releaseHeading): string
     {
@@ -62,8 +60,8 @@ protected function prepareCommonmarkEnvironment(): Environment
         ];
 
         $environment = new Environment($config);
-        $environment->addExtension(new CommonMarkCoreExtension());
-        $environment->addExtension(new HeadingPermalinkExtension());
+        $environment->addExtension(new CommonMarkCoreExtension);
+        $environment->addExtension(new HeadingPermalinkExtension);
 
         return $environment;
     }
@@ -74,12 +72,12 @@ protected function prepareCommonmarkEnvironment(): Environment
      */
     protected function attachPermalinkToHeading(Heading $releaseHeading, Environment $environment): Document
     {
-        $document = new Document();
+        $document = new Document;
         $document->appendChild($releaseHeading);
 
         $documentParsedEvent = new DocumentParsedEvent($document);
 
-        $processor = (new HeadingPermalinkProcessor());
+        $processor = (new HeadingPermalinkProcessor);
         $processor->setEnvironment($environment);
         $processor->__invoke($documentParsedEvent);
 
@@ -92,7 +90,7 @@ protected function attachPermalinkToHeading(Heading $releaseHeading, Environment
      */
     protected function extractLinkFragmentFromRenderedHtml(string $html): ?string
     {
-        $domDocument = new DOMDocument();
+        $domDocument = new DOMDocument;
         $domDocument->loadHTML($html);
 
         /** @var \DOMAttr $hrefAttribute */

app/Actions/InsertReleaseNotesInChangelogAction.php

@@ -10,9 +10,7 @@
 
 class InsertReleaseNotesInChangelogAction
 {
-    public function __construct(private readonly PrepareReleaseNotesAction $prepareReleaseNotes)
-    {
-    }
+    public function __construct(private readonly PrepareReleaseNotesAction $prepareReleaseNotes) {}
 
     /**
      * @throws ReleaseNotesCanNotBeplacedException
@@ -40,6 +38,6 @@ public function execute(Document $changelog, string $releaseNotes, Heading $newR
 
         // If the CHANGELOG doesn't have any children, we currently don't insert the release notes.
         // An exception is thrown and an error message is displayed to the user.
-        throw new ReleaseNotesCanNotBeplacedException();
+        throw new ReleaseNotesCanNotBeplacedException;
     }
 }

app/Actions/ParseAndLinkifyGitHubUsernamesAction.php

@@ -30,8 +30,8 @@ public function execute(?string $releaseNotes): ?string
         ];
 
         $environment = new Environment($config);
-        $environment->addExtension(new MarkdownRendererExtension());
-        $environment->addExtension(new MentionExtension());
+        $environment->addExtension(new MarkdownRendererExtension);
+        $environment->addExtension(new MentionExtension);
 
         $parser = new CommonmarkMarkdownParser($environment);
         $renderer = new CommonmarkRenderer($environment);

app/Actions/PlaceReleaseNotesAtTheTopAction.php

@@ -25,8 +25,7 @@ public function __construct(
         private readonly CreateNewReleaseHeadingWithCompareUrl $createNewReleaseHeadingWithCompareUrl,
         private readonly GenerateCompareUrl $generateCompareUrl,
         private readonly GitHubActionsOutput $gitHubActionsOutput,
-    ) {
-    }
+    ) {}
 
     /**
      * @throws Throwable

app/Actions/PlaceReleaseNotesBelowUnreleasedHeadingAction.php

@@ -22,8 +22,7 @@ public function __construct(
         private readonly CreateNewReleaseHeadingWithCompareUrl $createNewReleaseHeading,
         private readonly GitHubActionsOutput $gitHubActionsOutput,
         private readonly InsertReleaseNotesInChangelogAction $insertReleaseNotesInChangelogAction
-    ) {
-    }
+    ) {}
 
     /**
      * @throws Throwable

app/Actions/PrepareReleaseNotesAction.php

@@ -10,9 +10,7 @@
 
 class PrepareReleaseNotesAction
 {
-    public function __construct(private readonly Markdown $markdown, private readonly ShiftHeadingLevelInDocumentAction $shiftHeadingLevelInDocument)
-    {
-    }
+    public function __construct(private readonly Markdown $markdown, private readonly ShiftHeadingLevelInDocumentAction $shiftHeadingLevelInDocument) {}
 
     public function execute(string $releaseNotes, Heading $newReleaseHeading): Document
     {

app/Actions/ShiftHeadingLevelInDocumentAction.php

@@ -14,7 +14,7 @@ class ShiftHeadingLevelInDocumentAction
 
     public function execute(Document $document, int $baseHeadingLevel): Document
     {
-        $headings = (new Query())
+        $headings = (new Query)
             ->where(Query::type(Heading::class))
             ->findAll($document);
 

app/CreateNewReleaseHeading.php

@@ -10,9 +10,7 @@
 
 class CreateNewReleaseHeading
 {
-    public function __construct(private readonly ExtractPermalinkFragmentFromHeadingAction $extractPermalinkFragmentFromHeading)
-    {
-    }
+    public function __construct(private readonly ExtractPermalinkFragmentFromHeadingAction $extractPermalinkFragmentFromHeading) {}
 
     public function create(string $text, string $releaseDate, bool $hideDate = false): Heading
     {