Merge pull request #10 from stefanzweifel/input-validation

Validate Input Options

Author: stefanzweifel

app/Commands/UpdateCommand.php

@@ -8,6 +8,7 @@
 use LaravelZero\Framework\Commands\Command;
 use League\CommonMark\Output\RenderedContentInterface;
 use Throwable;
+use Webmozart\Assert\Assert;
 
 class UpdateCommand extends Command
 {
@@ -26,6 +27,8 @@ class UpdateCommand extends Command
      */
     public function handle(AddReleaseNotesToChangelog $addReleaseNotesToChangelog): void
     {
+        $this->validateOptions();
+
         $releaseNotes = $this->option('release-notes');
         $latestVersion = $this->option('latest-version');
         $releaseDate = $this->option('release-date');
@@ -61,4 +64,10 @@ protected function writeChangelogToFile(bool $shouldWriteToFile, string $pathToC
             file_put_contents($pathToChangelog, $updatedMarkdown->getContent());
         }
     }
+
+    private function validateOptions(): void
+    {
+        Assert::stringNotEmpty($this->option('release-notes'), 'No release-notes option provided. Abort.');
+        Assert::stringNotEmpty($this->option('latest-version'), 'No latest-version option provided. Abort.');
+    }
 }

composer.json

@@ -16,6 +16,7 @@
     "require": {
         "php": "^8.0",
         "league/commonmark": "^2.0",
+        "webmozart/assert": "^1.10",
         "wnx/commonmark-markdown-renderer": "^1.0"
     },
     "require-dev": {

composer.lock

@@ -24,11 +24,16 @@
 });
 
 it('throws error if release-notes are missing', function () {
-    $this->markTestIncomplete('TODO: Add Validation to Update Command');
+    $this->artisan('update', [])
+       ->assertExitCode(1);
+})->throws(InvalidArgumentException::class, 'No release-notes option provided. Abort.');
 
-    $this->artisan('update')
+it('throws error if latest-version is missing', function () {
+    $this->artisan('update', [
+        '--release-notes' => '::release-notes::',
+        ])
        ->assertExitCode(1);
-});
+})->throws(InvalidArgumentException::class, 'No latest-version option provided. Abort.');
 
 it('uses current date for release date if no option is provieded', function () {
     $expectedChangelog = file_get_contents(__DIR__ . '/../Stubs/expected-changelog.md');