Bump version to 23.0.0 (#1582)

### What
Bump version to 23.0.0, creating release branch.

### Why
Triggered by @sisuresh in
https://github.com/stellar/rs-soroban-env/actions/runs/16816319373.

### What is next

See the release instructions for a full rundown on the release process:
https://github.com/stellar/actions/blob/main/README-rust-release.md

Commit any changes to the `release/v23.0.0` branch that are needed in
this release.

If this is a regular release releasing from `main`, merge this PR when
ready, and after merging, create a release for this version by going to
this link:
https://github.com/stellar/rs-soroban-env/releases/new?tag=v23.0.0&title=23.0.0

If this is a backport or patch release of a past version, see the
release instructions. When ready to release this branch create a release
by going to this link:

https://github.com/stellar/rs-soroban-env/releases/new?tag=v23.0.0&title=23.0.0&target=release/v23.0.0

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Siddharth Suresh <siddharth@stellar.org>

Author: github-actions[bot]

.github/workflows/rust.yml

@@ -63,10 +63,10 @@ jobs:
     steps:
     - uses: actions/checkout@v3
     - run: rustup update
-    - uses: stellar/binaries@v38
+    - uses: stellar/binaries@v40
       with:
         name: cargo-semver-checks
-        version: 0.41.0
+        version: 0.42.0
     - run: cargo semver-checks --exclude soroban-simulation
 
   build-and-test:
@@ -110,7 +110,7 @@ jobs:
     - run: rustup update
     - run: cargo version
     - run: rustup target add ${{ matrix.sys.target }}
-    - uses: stellar/binaries@v37
+    - uses: stellar/binaries@v40
       with:
         name: cargo-hack
         version: 0.6.35

Cargo.lock

@@ -20,21 +20,21 @@ exclude = ["soroban-test-wasms/wasm-workspace"]
 # NB: When bumping the major version make sure to clean up the
 # code guarded by `unstable-*` features to make it enabled
 # unconditionally.
-version = "23.0.0-rc.3"
+version = "23.0.0"
 rust-version = "1.84.0"
 
 [workspace.dependencies]
-soroban-env-common = { version = "=23.0.0-rc.3", path = "soroban-env-common", default-features = false }
-soroban-env-guest = { version = "=23.0.0-rc.3", path = "soroban-env-guest" }
-soroban-env-host = { version = "=23.0.0-rc.3", path = "soroban-env-host" }
-soroban-env-macros = { version = "=23.0.0-rc.3", path = "soroban-env-macros" }
-soroban-builtin-sdk-macros = { version = "=23.0.0-rc.3", path = "soroban-builtin-sdk-macros" }
+soroban-env-common = { version = "=23.0.0", path = "soroban-env-common", default-features = false }
+soroban-env-guest = { version = "=23.0.0", path = "soroban-env-guest" }
+soroban-env-host = { version = "=23.0.0", path = "soroban-env-host" }
+soroban-env-macros = { version = "=23.0.0", path = "soroban-env-macros" }
+soroban-builtin-sdk-macros = { version = "=23.0.0", path = "soroban-builtin-sdk-macros" }
 # NB: this must match the wasmparser version wasmi is using
 wasmparser = "=0.116.1"
 
 # NB: When updating, also update the version in rs-soroban-env dev-dependencies
 [workspace.dependencies.stellar-xdr]
-version = "=23.0.0-rc.3"
+version = "=23.0.0"
 # git = "https://github.com/stellar/rs-stellar-xdr"
 # rev = "1a00274ac9c93d580cc4f5eba787906e759d632a"
 default-features = false

Cargo.toml

@@ -83,7 +83,7 @@ k256 = {version = "0.13.1", default-features = false, features = ["alloc"]}
 p256 = {version = "0.13.2", default-features = false, features = ["alloc"]}
 
 [dev-dependencies.stellar-xdr]
-version = "=23.0.0-rc.3"
+version = "=23.0.0"
 # git = "https://github.com/stellar/rs-stellar-xdr"
 # rev = "1a00274ac9c93d580cc4f5eba787906e759d632a"
 default-features = false

soroban-env-host/Cargo.toml

@@ -151,6 +151,8 @@ mod v21 {
     }
 
     // This cost-type is recycled as unrefined-model, parse-only phase.
+    // TODO: Figure out how to handle this better.
+    #[allow(dead_code)]
     pub struct VmInstantiationRun;
     // This cost-type is recycled as unrefined-model, instantiate-only phase.
     pub struct VmCachedInstantiationRun;

soroban-env-host/src/cost_runner/cost_types/vm_ops.rs

@@ -80,14 +80,14 @@ impl StellarAssetContractTest {
     fn default_stellar_asset_contract_with_admin_id(
         &self,
         new_admin: &Address,
-    ) -> TestStellarAssetContract {
+    ) -> TestStellarAssetContract<'_> {
         let contract = self.default_stellar_asset_contract();
         let issuer = TestSigner::account(&self.issuer_key);
         contract.set_admin(&issuer, new_admin.clone()).unwrap();
         contract
     }
 
-    fn default_stellar_asset_contract(&self) -> TestStellarAssetContract {
+    fn default_stellar_asset_contract(&self) -> TestStellarAssetContract<'_> {
         let issuer_id = signing_key_to_account_id(&self.issuer_key);
         self.create_account(
             &issuer_id,

soroban-env-host/src/test/stellar_asset_contract.rs

@@ -54,7 +54,7 @@ impl Default for ModuleCacheMap {
 impl ModuleCacheMap {
     fn lock_map(
         map: &Arc<Mutex<BTreeMap<Hash, Arc<ParsedModule>>>>,
-    ) -> Result<MutexGuard<BTreeMap<Hash, Arc<ParsedModule>>>, HostError> {
+    ) -> Result<MutexGuard<'_, BTreeMap<Hash, Arc<ParsedModule>>>, HostError> {
         map.lock()
             .map_err(|_| HostError::from((ScErrorType::Context, ScErrorCode::InternalError)))
     }