Skip to content

Commit 22bf6ff

Browse files
authored
Fix: remove the default "false" value for ENABLE_EMBEDDED_WALLETS (#1049)
### What 1. `matrix.ENABLE_EMBEDDED_WALLETS` default value "false" is a non-empty string, prevents docker compose defaults to kicks in 2. update`run_embedded_wallet_test.sh` and `changelog` ### Why Integration tests failed due to "embedded wallets feature is disabled" https://github.com/stellar/stellar-disbursement-platform-backend/actions/runs/21842255128/job/63036397368 ### Known limitations N/A ### Checklist - [x] Title follows `SDP-1234: Add new feature` or `Chore: Refactor package xyz` format. The Jira ticket code was included if available. - [ ] PR has a focused scope and doesn't mix features with refactoring - [ ] Tests are included (if applicable) - [x] `CHANGELOG.md` is updated (if applicable) - [ ] If contracts changed, run the `Contract WASM Artifacts` workflow and open a PR to update the WASMs on `dev` - [ ] CONFIG/SECRETS changes are updated in helmcharts and deployments (if applicable) - [ ] Preview deployment works as expected - [ ] Ready for production
1 parent cf3901a commit 22bf6ff

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

.github/workflows/e2e_integration_test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ jobs:
9898
HORIZON_URL: ${{ matrix.HORIZON_URL }}
9999
CIRCLE_API_TYPE: ${{ matrix.CIRCLE_API_TYPE || 'TRANSFERS' }}
100100
RPC_URL: ${{ matrix.RPC_URL }}
101-
ENABLE_EMBEDDED_WALLETS: ${{ matrix.ENABLE_EMBEDDED_WALLETS || 'false' }}
101+
ENABLE_EMBEDDED_WALLETS: ${{ matrix.ENABLE_EMBEDDED_WALLETS}}
102102
EMBEDDED_WALLETS_WASM_HASH: ${{ matrix.EMBEDDED_WALLETS_WASM_HASH }}
103103
TEST_TYPE: ${{ matrix.TEST_TYPE }}
104104
steps:

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog](https://keepachangelog.com/).
66

7+
## [Unreleased]
8+
9+
### Added
10+
11+
- Add integration tests for embedded wallets. [1041](https://github.com/stellar/stellar-disbursement-platform-backend/pull/1041)
12+
713
## [6.1.0](https://github.com/stellar/stellar-disbursement-platform-backend/releases/tag/6.1.0) ([diff](https://github.com/stellar/stellar-disbursement-platform-backend/compare/6.0.1...6.1.0))
814

915
### Fixed

internal/integrationtests/run_embedded_wallet_test.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ export USER_EMAIL="integration-test-user@stellar.local"
2020
export USER_PASSWORD="Password123!"
2121
export ENABLE_EMBEDDED_WALLETS="true"
2222
export TEST_TYPE="embedded-wallet"
23+
export RPC_URL="${RPC_URL:-https://soroban-testnet.stellar.org}"
24+
export EMBEDDED_WALLETS_WASM_HASH="${EMBEDDED_WALLETS_WASM_HASH:-9b784817dff1620a3e2b223fe1eb8dac56e18980dea9726f692847ccbbd3a853}"
2325

2426
# Cleanup
2527
echo "====> Step 1: Cleanup"

0 commit comments

Comments
 (0)