Merge pull request #33 from stellarwp/fix-version-compare-on-null

borkweb · web-flow · commit afef7300c8d6 · 2024-01-09T08:56:29.000-05:00
Prevent version_compare on null
diff --git a/src/Schema/Tables/Contracts/Table.php b/src/Schema/Tables/Contracts/Table.php
@@ -438,7 +438,7 @@ public function is_schema_current() {
 			// @todo Error?
 		}
 
-		$version_applied = $this->get_stored_version();
+		$version_applied = $this->get_stored_version() ?: '';
 		$current_version = $this->get_version();
 
 		return version_compare( $version_applied, $current_version, '==' );

Original file line number	Diff line number	Diff line change
`@@ -438,7 +438,7 @@ public function is_schema_current() {`
`438`	`438`	`// @todo Error?`
`439`	`439`	`}`
`440`	`440`
`441`		`- $version_applied = $this->get_stored_version();`
	`441`	`+ $version_applied = $this->get_stored_version() ?: '';`
`442`	`442`	`$current_version = $this->get_version();`
`443`	`443`
`444`	`444`	`return version_compare( $version_applied, $current_version, '==' );`