Skip to content

Update type declarations, should also work if context is undefined #15

@DesignByOnyx

Description

@DesignByOnyx

There are two issues with the way the component is today - I am wrapping them up in one issue as I am about to file a PR.

Issue 1: type declarations for Diagnostic are out of sync with stencil/core. Specifically the "level" and "type" properties need to be loosened into string instead of the enum which is there currently. This is the same change which has already been applied in stencil/sass.

Issue 2:

UPDATE: The type definitions were updated after I opened this issue and my PR. Hence the strikethrough above.

In my project, I am importing css from a 3rd party module like this:

@import '@our-company/global-styles';

but the imported CSS file is not being processed due to context being undefined. By moving the context check to a different place, I am able to import our CSS successfully (you will see in the PR). If you have a better suggestion on how to fix this, I will gladly implement it.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions