bug: angular component does not define required inputs

[maciej-klemarczyk-se]

Prerequisites

• I have read the Contributing Guidelines.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already report this problem, without success.

Stencil Version

4.35.1

Stencil Framework Output Target

Angular

Stencil Framework Output Target Version

1.0.0

Current Behavior

I define the component as required according to Stencil documentation : https://stenciljs.com/docs/properties#required-properties

But in the wrapper/proxy library for Angular the property is not defined as required.

@Component({
  selector: 'my-component',
  changeDetection: ChangeDetectionStrategy.OnPush,
  template: '<ng-content></ng-content>',
  // eslint-disable-next-line @angular-eslint/no-inputs-metadata-property
  inputs: ['checkboxOnly'],
})

Expected Behavior

I expect that such properties will be defined as required in Angular proxy.

@Component({
  selector: 'my-component',
  changeDetection: ChangeDetectionStrategy.OnPush,
  template: '<ng-content></ng-content>',
  // eslint-disable-next-line @angular-eslint/no-inputs-metadata-property
  inputs: [{name:'checkboxOnly', required:true}],
})

Steps to Reproduce

Create new stencil with one component and mark one of the properties as required.

Code Reproduction URL

Unable to share the library.

Additional Information

I searched the documentation and Angular integration documentation does not specify that I need some special configuration for this behavior. At the moment the stencil created bad quality Angular wrapper library.

[maciej-klemarczyk-se]

I noticed that in code itself, there is no processing "required" attribute for inputs in Angular components.

output-targets/packages/angular/src/generate-angular-component.ts

Line 79 in 9f20ee0

proxyCmpOptions.push(`\n inputs: [${formattedInputs}]`);

[christian-bromann]

@gratzl-dev any clues?

[gratzl-dev]

This is not implemented in the angular output template yet
But it would be a nice thing to have for sure!

[christian-bromann]

Thanks for confirming. Any contributions to this feature would be much appreciated.

[mklemarczyk]

Hello, I am new to the community. I would like to propose the contribution to address this behavior.
I did not tested it yet (that is why the PR is a draft). I would appreciate your input about code style, syntax and quality.
#673

[mklemarczyk]

I tested version @stencil/angular-output-target@1.1.0, it works great.
The issue can be closed for me.