PostProcessing: Fix texture hazard when stages disabled

stenzek · stenzek · commit eda65a6ae25b · 2026-02-05T13:00:24.000+10:00
diff --git a/src/util/postprocessing.cpp b/src/util/postprocessing.cpp
@@ -429,8 +429,10 @@ PostProcessing::Chain::~Chain() = default;
 
 GPUTexture* PostProcessing::Chain::GetTextureUnusedAtEndOfChain() const
 {
-  return (m_stages.size() % 2) ? m_output_texture.get() :
-                                 (m_intermediate_texture ? m_intermediate_texture.get() : m_input_texture.get());
+  const size_t num_active_stages = std::ranges::count_if(
+    m_stages, [](const std::unique_ptr<Shader>& shader) { return (shader && shader->IsEnabled()); });
+  return (num_active_stages % 2) ? m_output_texture.get() :
+                                   (m_intermediate_texture ? m_intermediate_texture.get() : m_input_texture.get());
 }
 
 bool PostProcessing::Chain::IsActive() const

Original file line number	Diff line number	Diff line change
`@@ -429,8 +429,10 @@ PostProcessing::Chain::~Chain() = default;`
`429`	`429`
`430`	`430`	`GPUTexture* PostProcessing::Chain::GetTextureUnusedAtEndOfChain() const`
`431`	`431`	`{`
`432`		`- return (m_stages.size() % 2) ? m_output_texture.get() :`
`433`		`- (m_intermediate_texture ? m_intermediate_texture.get() : m_input_texture.get());`
	`432`	`+ const size_t num_active_stages = std::ranges::count_if(`
	`433`	`+ m_stages, [](const std::unique_ptr<Shader>& shader) { return (shader && shader->IsEnabled()); });`
	`434`	`+ return (num_active_stages % 2) ? m_output_texture.get() :`
	`435`	`+ (m_intermediate_texture ? m_intermediate_texture.get() : m_input_texture.get());`
`434`	`436`	`}`
`435`	`437`
`436`	`438`	`bool PostProcessing::Chain::IsActive() const`