Merge pull request #383 from step-security/revert-userns-1

Revert docker-user mapping

Author: varunsh-coder

dnsconfig.go

@@ -48,7 +48,7 @@ func updateDockerConfig(configPath string) error {
 
 	m["dns"] = []string{dockerDnsServer}
 	m["live-restore"] = true
-	m["userns-remap"] = "runner:runner" // Checkout: https://docs.docker.com/engine/security/userns-remap/#enable-userns-remap-on-the-daemon
+	// m["userns-remap"] = "runner:runner" // Checkout: https://docs.docker.com/engine/security/userns-remap/#enable-userns-remap-on-the-daemon
 
 	config, err := json.Marshal(m)
 	if err != nil {

dnsconfig_test.go

@@ -41,11 +41,11 @@ func Test_updateDockerConfig(t *testing.T) {
 	}{
 		{name: "existing file",
 			args:    args{configPath: tmpFileName},
-			want:    "{\"cgroup-parent\":\"/actions_job\",\"dns\":[\"172.17.0.1\"],\"live-restore\":true,\"userns-remap\":\"runner:runner\"}",
+			want:    "{\"cgroup-parent\":\"/actions_job\",\"dns\":[\"172.17.0.1\"],\"live-restore\":true}",
 			wantErr: false},
 		{name: "non existent file",
 			args:    args{configPath: mockDockerConfigPath},
-			want:    "{\"dns\":[\"172.17.0.1\"],\"live-restore\":true,\"userns-remap\":\"runner:runner\"}",
+			want:    "{\"dns\":[\"172.17.0.1\"],\"live-restore\":true}",
 			wantErr: false},
 	}