Skip to content

Commit ad10892

Browse files
Merge pull request #1643 from Devils-Knight/issue
[ISSUE] Update Names of `WorkflowParameters` struct properties to UpperCase
2 parents 582a89d + ee52f8f commit ad10892

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

remediation/workflow/addworkflow.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ import (
1212
const CodeQLWorkflowFileName = "codeql.yml"
1313

1414
type WorkflowParameters struct {
15-
languagesToAdd []string
16-
defaultBranch string
15+
LanguagesToAdd []string
16+
DefaultBranch string
1717
}
1818

1919
func getTemplate(file string) (string, error) {
@@ -38,9 +38,9 @@ func AddWorkflow(name string, workflowParameters WorkflowParameters) (string, er
3838
return "", err
3939
}
4040

41-
sort.Strings(workflowParameters.languagesToAdd)
42-
codeqlWorkflow = strings.ReplaceAll(codeqlWorkflow, "$default-branch", fmt.Sprintf(`"%s"`, workflowParameters.defaultBranch))
43-
codeqlWorkflow = strings.ReplaceAll(codeqlWorkflow, "$detected-codeql-languages", strings.Join(workflowParameters.languagesToAdd, ", "))
41+
sort.Strings(workflowParameters.LanguagesToAdd)
42+
codeqlWorkflow = strings.ReplaceAll(codeqlWorkflow, "$default-branch", fmt.Sprintf(`"%s"`, workflowParameters.DefaultBranch))
43+
codeqlWorkflow = strings.ReplaceAll(codeqlWorkflow, "$detected-codeql-languages", strings.Join(workflowParameters.LanguagesToAdd, ", "))
4444
codeqlWorkflow = strings.ReplaceAll(codeqlWorkflow, "$cron-weekly", fmt.Sprintf(`"%s"`, "0 0 * * 1")) // Note: Runs every monday at 12:00 AM
4545

4646
return codeqlWorkflow, nil

remediation/workflow/addworkflow_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,17 @@ func Test_AddWorkflow(t *testing.T) {
1616
{
1717
workflowName: "codeql",
1818
workflowParameters: WorkflowParameters{
19-
languagesToAdd: []string{"cpp", "go", "java"},
20-
defaultBranch: "main",
19+
LanguagesToAdd: []string{"cpp", "go", "java"},
20+
DefaultBranch: "main",
2121
},
2222
expectedError: false,
2323
expectedOutputFile: "../../testfiles/expected-codeql.yml",
2424
},
2525
{
2626
workflowName: "xyz",
2727
workflowParameters: WorkflowParameters{
28-
languagesToAdd: []string{"cpp"},
29-
defaultBranch: "main",
28+
LanguagesToAdd: []string{"cpp"},
29+
DefaultBranch: "main",
3030
},
3131
expectedError: true,
3232
expectedOutputFile: "",

0 commit comments

Comments
 (0)