Code cleanup

Author: ddd999

server/index.js

@@ -832,12 +832,6 @@ try {
       }
       winston.info(`Camera started successfully in ${mode} mode.`);
 
-    // ---> ADD LOGGING <---
-    console.log("--- /api/camera/start Sending Response ---");
-    console.log("Start result:", { active, addresses });
-    console.log("-----------------------------------------");
-    // ---> END LOGGING <---
-
       res.send(JSON.stringify({ active: active, addresses: addresses || [], error: null }));
     });
 
@@ -863,39 +857,6 @@ vManager.stopCamera((err, active) => { // active should be false after stop
 });
 });
 
-//     if (!err) {
-//       winston.error('Error getting video devices:', err);
-//       res.setHeader('Content-Type', 'application/json')
-//       res.send(JSON.stringify({
-//         ifaces: vManager.ifaces,
-//         dev: devices,
-//         vidDeviceSelected: seldevice,
-//         vidres: vidres,
-//         vidResSelected: selRes,
-//         streamingStatus: active,
-//         streamAddresses: vManager.deviceAddresses,
-//         rotSelected: selRot,
-//         bitrate: selbitrate,
-//         fpsSelected: selfps,
-//         UDPChecked: SeluseUDP,
-//         useUDPIP: SeluseUDPIP,
-//         useUDPPort: SeluseUDPPort,
-//         timestamp,
-//         error: null,
-//         fps: fps,
-//         FPSMax: FPSMax,
-//         enableCameraHeartbeat: useCameraHeartbeat,
-//         mavStreamSelected: selMavURI,
-//         cameraMode: selCameraMode
-//       }))
-//     } else {
-//       res.setHeader('Content-Type', 'application/json')
-//       res.send(JSON.stringify({ error: err }))
-//       winston.info('Error in /api/videodevices ', { message: err })
-//     }
-//   })
-// })
-
 app.get('/api/hardwareinfo', authenticateToken, (req, res) => {
   aboutPage.getHardwareInfo((RAM, CPU, hatData, sysData, err) => {
     if (!err) {
@@ -1137,45 +1098,6 @@ app.get('/api/networkconnections', authenticateToken, (req, res) => {
   })
 })
 
-// app.post('/api/startstopvideo', authenticateToken, [check('active').isBoolean(),
-//   check('device').if(check('active').isIn([true])).isLength({ min: 2 }),
-//   check('height').if(check('active').isIn([true])).isInt({ min: 1 }),
-//   check('width').if(check('active').isIn([true])).isInt({ min: 1 }),
-//   check('useUDP').if(check('active').isIn([true])).isBoolean(),
-//   check('useTimestamp').if(check('active').isIn([true])).isBoolean(),
-//   check('useCameraHeartbeat').if(check('active').isIn([true])).isBoolean(),
-//   check('cameraMode').if(check('active').isIn([true])).isIn(['streaming', 'photo', 'video']),
-//   check('useUDPPort').if(check('active').isIn([true])).isPort(),
-//   check('useUDPIP').if(check('active').isIn([true])).isIP(),
-//   check('bitrate').if(check('active').isIn([true])).isInt({ min: 50, max: 50000 }),
-//   check('format').if(check('active').isIn([true])).isIn(['video/x-raw', 'video/x-h264', 'image/jpeg']),
-//   check('fps').if(check('active').isIn([true])).isInt({ min: -1, max: 100 }),
-//   check('rotation').if(check('active').isIn([true])).isInt().isIn([0, 90, 180, 270])],
-//   check('compression').if(check('active').isIn([true])).isIn(['H264', 'H265']), (req, res) => {
-//   const errors = validationResult(req)
-//   if (!errors.isEmpty()) {
-//     winston.info('Bad POST vars in /api/startstopvideo ', { message: errors.array() })
-//     const ret = { streamingStatus: false, streamAddresses: [], error: ['Error ' + JSON.stringify(errors.array())] }
-//     return res.status(422).json(ret)
-//   }
-//   // user wants to start/stop video streaming
-//   vManager.startStopStreaming(req.body.active, req.body.device, req.body.height, req.body.width, req.body.format, req.body.rotation,
-//                               req.body.bitrate, req.body.fps, req.body.useUDP, req.body.useUDPIP, req.body.useUDPPort,
-//                               req.body.useTimestamp, req.body.useCameraHeartbeat, req.body.mavStreamSelected, req.body.cameraMode,
-//                               req.body.compression, (err, status, addresses) => {
-//     if (!err) {
-//       res.setHeader('Content-Type', 'application/json')
-//       const ret = { streamingStatus: status, streamAddresses: addresses }
-//       res.send(JSON.stringify(ret))
-//     } else {
-//       res.setHeader('Content-Type', 'application/json')
-//       const ret = { streamingStatus: false, streamAddresses: ['Error ' + err] }
-//       res.send(JSON.stringify(ret))
-//       winston.info('Error in /api/startstopvideo ', { message: err })
-//     }
-//   })
-// })
-
 // Get details of a network connection by connection ID
 app.post('/api/networkIP', authenticateToken, [check('conName').isUUID()], (req, res) => {
   // Finds the validation errors in this request and wraps them in an object with handy functions