mypy: Start checking tests

We were only passing testtools to mypy, which meant tests were never getting
run through mypy. Fixing this highlights a large number of issues that must
be resolved.

Signed-off-by: Stephen Finucane <stephen@that.guru>

Author: stephenfin

.github/workflows/test.yml

@@ -32,12 +32,12 @@ jobs:
 
       - name: Ruff
         run: |
-          python -m ruff check .
-          python -m ruff format --check .
+          python -m ruff check
+          python -m ruff format --check
 
       - name: Type Check
         run: |
-          python -m mypy testtools
+          python -m mypy
 
   test:
     runs-on: ubuntu-latest

pyproject.toml

@@ -69,6 +69,10 @@ warn_unused_ignores = false
 # FIXME(stephenfin): We should remove this
 implicit_reexport = true
 exclude = 'doc'
+files = [
+    "testtools",
+    "tests",
+]
 
 [[tool.mypy.overrides]]
 module = [

tox.ini

@@ -14,11 +14,11 @@ commands =
 deps =
   ruff
 commands =
-  ruff check --fix .
-  ruff format .
+  ruff check --fix
+  ruff format
 
 [testenv:mypy]
 deps =
   mypy
 commands =
-  mypy --cache-dir="{envdir}/mypy_cache" {posargs:testtools}
+  mypy --cache-dir="{envdir}/mypy_cache" {posargs}