fix functino caller to catch exceptions

Author: stephenfreund

src/flowco/ui/page_files/base_page.py

@@ -1,10 +1,7 @@
-from pprint import pformat
 from flowco.dataflow.extended_type import schema_to_text
-from flowco.session.session import session
 import uuid
 
 from flowco.page.ama import AskMeAnything, VisibleMessage
-from flowco.session.session_file_system import fs_write
 from flowco.ui import ui_help
 from flowco.ui.authenticate import sign_out
 import numpy as np
@@ -20,6 +17,7 @@
 from flowco.ui.ui_page import st_abstraction_level
 from flowco.ui.ui_util import (
     toggle,
+    zip_bug,
 )
 import streamlit as st
 
@@ -30,8 +28,7 @@
 from flowco.util.config import config
 from flowco.util.costs import inflight, total_cost
 from flowco.util.config import AbstractionLevel
-from flowco.util.files import create_zip_in_memory
-from flowco.util.output import Output, error, log, log_timestamp
+from flowco.util.output import error, log
 
 
 class FlowcoPage:
@@ -390,14 +387,6 @@ def bottom_bar(self):
                     st.rerun()
 
     def report_bug(self):
-        ui_page = st.session_state.ui_page
-        flowco_name = ui_page.page().file_name
-        data_files = [
-            file for file in ui_page.page().tables.all_files() if file.endswith(".csv")
-        ]
-        time_stamp = log_timestamp()
-        file_name = f"flowco-{time_stamp}.zip"
-
         @st.dialog("Report Bug", width="small")
         def download_files():
 
@@ -408,17 +397,7 @@ def download_files():
 
             if text:
                 with st.spinner("Creating ZIP file..."):
-                    zip_data = create_zip_in_memory(
-                        [flowco_name] + data_files,
-                        additional_entries={
-                            "description.txt": text,
-                            "logging.txt": session.get(
-                                "output", Output
-                            ).get_full_output(),
-                            "session_state.json": pformat(dict(st.session_state)),
-                        },
-                    )
-                    fs_write(file_name, zip_data, "wb")
+                    file_name, zip_data = zip_bug(text)
 
                 st.write("Saved on server.  Click below to download bug files locally.")
 

src/flowco/ui/ui_main.py

@@ -6,6 +6,7 @@
 from flowco.ui.ui_init import st_init
 from flowco.ui.ui_page import UIPage, set_ui_page
 from flowco.ui.ui_st_pages import st_pages
+from flowco.ui.ui_util import zip_bug
 from flowco.util.files import setup_flowco_files
 import streamlit as st
 
@@ -63,6 +64,10 @@ def init_service():
     print(traceback.format_exc())
     st.error(e)
     st.exception(e)
+    try:
+        zip_bug(f"""{str(e)}\n{traceback.format_exc()}""")
+    except Exception as e2:
+        print("Error zipping bug report", e2)
     print("Restarting Session Components...")
     if os.path.isdir(st.session_state.args.page):
         page_path = os.path.abspath(st.session_state.args.page)

src/flowco/ui/ui_util.py

@@ -1,15 +1,17 @@
-import functools
-import pandas as pd
+from pprint import pformat
 import streamlit as st
 
-from typing import Any, Callable, Iterator, List
+from typing import Callable, Iterator, List
 import uuid
 
 from streamlit_extras.stylable_container import stylable_container
 
-from flowco.dataflow.dfg import Node
 from flowco.dataflow.phase import Phase
+from flowco.session.session import session
+from flowco.session.session_file_system import fs_write
 from flowco.util.config import AbstractionLevel
+from flowco.util.files import create_zip_in_memory
+from flowco.util.output import Output, log_timestamp
 
 
 def editable_list(
@@ -173,3 +175,23 @@ def phase_for_last_shown_part() -> Phase:
         return Phase.requirements
     else:
         return Phase.clean
+
+
+def zip_bug(description):
+    ui_page = st.session_state.ui_page
+    flowco_name = ui_page.page().file_name
+    data_files = [
+        file for file in ui_page.page().tables.all_files() if file.endswith(".csv")
+    ]
+    time_stamp = log_timestamp()
+    file_name = f"flowco-{time_stamp}.zip"
+    zip_data = create_zip_in_memory(
+        [flowco_name] + data_files,
+        additional_entries={
+            "description.txt": description,
+            "logging.txt": session.get("output", Output).get_full_output(),
+            "session_state.json": pformat(dict(st.session_state)),
+        },
+    )
+    fs_write(file_name, zip_data, "wb")
+    return file_name, zip_data

src/llm/assistant.py

@@ -241,7 +241,11 @@ def make_call(
 
         self.logger.log(f"Tool call: {function_name}")
 
-        result = function_def.function(**args)
+        try:
+            result = function_def.function(**args)
+        except Exception as e:
+            self.logger.error(f"Error in tool call {function_name}: {e}")
+            result = ToolCallResult(user_message=f"An error occurred: {e}")
 
         self.logger.log(f"Tool result: {result}")