GetDirectBufferCapacity() may return -1, but shouldn't throw exception

Author: stephengold

src/main/native/glue/com_jme3_bullet_collision_shapes_CompoundCollisionShape.cpp

@@ -83,7 +83,8 @@ JNIEXPORT void JNICALL Java_com_jme3_bullet_collision_shapes_CompoundCollisionSh
     // no check for exceptions!
     NULL_CHK(pEnv, pBuffer, "The mass buffer is not direct.",);
     const jlong capacityFloats = pEnv->GetDirectBufferCapacity(massBuffer);
-    EXCEPTION_CHK(pEnv,);
+    // no check for exceptions!
+    btAssert(capacityFloats != -1);
 
     const int numChildren = pShape->getNumChildShapes();
     btTransform principal;

src/main/native/glue/com_jme3_bullet_collision_shapes_HullCollisionShape.cpp

@@ -73,7 +73,8 @@ JNIEXPORT jlong JNICALL Java_com_jme3_bullet_collision_shapes_HullCollisionShape
 
     NULL_CHK(pEnv, buffer, "The buffer does not exist.", 0);
     const jlong capacityFloats = pEnv->GetDirectBufferCapacity(buffer);
-    EXCEPTION_CHK(pEnv, 0);
+    // no check for exceptions!
+    btAssert(capacityFloats != -1);
     if (capacityFloats < 3 * n) {
         pEnv->ThrowNew(jmeClasses::IllegalArgumentException,
                 "The buffer is too small.");
@@ -112,7 +113,8 @@ JNIEXPORT void JNICALL Java_com_jme3_bullet_collision_shapes_HullCollisionShape_
 
     NULL_CHK(pEnv, storeBuffer, "The store buffer does not exist.",);
     const jlong capacityFloats = pEnv->GetDirectBufferCapacity(storeBuffer);
-    EXCEPTION_CHK(pEnv,);
+    // no check for exceptions!
+    btAssert(capacityFloats != -1);
     int numVerts = pShape->getNumPoints();
     jlong floatsNeeded = 3 * (jlong) numVerts;
     if (floatsNeeded > capacityFloats) {

src/main/native/glue/com_jme3_bullet_collision_shapes_infos_IndexedMesh.cpp

@@ -382,15 +382,17 @@ JNIEXPORT void JNICALL Java_com_jme3_bullet_collision_shapes_infos_IndexedMesh_f
     NULL_CHK(pEnv, pVertices, "The position buffer is not direct.",);
     // no check for exceptions!
     const jlong capacityFloats = pEnv->GetDirectBufferCapacity(floatBuffer);
-    EXCEPTION_CHK(pEnv,);
+    // no check for exceptions!
+    btAssert(capacityFloats != -1);
     btAssert(capacityFloats == 3 * pMesh->m_numVertices);
 
     NULL_CHK(pEnv, intBuffer, "The index buffer does not exist.",);
     jint * const pIndices = (jint *) pEnv->GetDirectBufferAddress(intBuffer);
     NULL_CHK(pEnv, pIndices, "The index buffer is not direct.",);
     // no check for exceptions!
     const jlong capacityInts = pEnv->GetDirectBufferCapacity(intBuffer);
-    EXCEPTION_CHK(pEnv,);
+    // no check for exceptions!
+    btAssert(capacityInts != -1);
     btAssert(capacityInts == 3 * pMesh->m_numTriangles);
 
     jint * const pMeshIndices = (jint *) pMesh->m_triangleIndexBase;

src/main/native/glue/com_jme3_bullet_objects_PhysicsSoftBody.cpp

@@ -1073,7 +1073,8 @@ JNIEXPORT void JNICALL Java_com_jme3_bullet_objects_PhysicsSoftBody_getMasses
     // no check for exceptions!
 
     const jlong capacityFloats = pEnv->GetDirectBufferCapacity(massBuffer);
-    EXCEPTION_CHK(pEnv,);
+    // no check for exceptions!
+    btAssert(capacityFloats != -1);
     int numNodes = pBody->m_nodes.size();
     for (int i = 0; i < numNodes && i < capacityFloats; ++i) {
         pMasses[i] = pBody->getMass(i);
@@ -1729,7 +1730,8 @@ JNIEXPORT void JNICALL Java_com_jme3_bullet_objects_PhysicsSoftBody_setMasses
     // no check for exceptions!
 
     const jlong capacityFloats = pEnv->GetDirectBufferCapacity(massBuffer);
-    EXCEPTION_CHK(pEnv,);
+    // no check for exceptions!
+    btAssert(capacityFloats != -1);
     int numNodes = pBody->m_nodes.size();
     for (int i = 0; i < numNodes && i < capacityFloats; ++i) {
         pBody->setMass(i, pBuffer[i]);
@@ -1774,7 +1776,8 @@ JNIEXPORT void JNICALL Java_com_jme3_bullet_objects_PhysicsSoftBody_setNormals
 
     const jlong capacityFloats
             = pEnv->GetDirectBufferCapacity(normalBuffer) - 2;
-    EXCEPTION_CHK(pEnv,);
+    // no check for exceptions!
+    btAssert(capacityFloats != -3);
     int numNodes = pBody->m_nodes.size();
     for (int nodeIndex = 0, offset = 0;
             nodeIndex < numNodes && offset < capacityFloats;) {
@@ -1919,7 +1922,8 @@ JNIEXPORT void JNICALL Java_com_jme3_bullet_objects_PhysicsSoftBody_setVelocitie
 
     const jlong capacityFloats
             = pEnv->GetDirectBufferCapacity(velocityBuffer) - 2;
-    EXCEPTION_CHK(pEnv,);
+    // no check for exceptions!
+    btAssert(capacityFloats != -3);
     int numNodes = pBody->m_nodes.size();
     for (int nodeIndex = 0, offset = 0;
             nodeIndex < numNodes && offset < capacityFloats;) {

src/main/native/glue/com_jme3_bullet_util_NativeSoftBodyUtil.cpp

@@ -98,7 +98,8 @@ JNIEXPORT void JNICALL Java_com_jme3_bullet_util_NativeSoftBodyUtil_updateMesh__
     // no check for exceptions!
 
     const jlong mapCapacityInts = pEnv->GetDirectBufferCapacity(indexMap);
-    EXCEPTION_CHK(pEnv,);
+    // no check for exceptions!
+    btAssert(mapCapacityInts != -1);
     const btVector3 offset
             = (meshInLocalSpace ? getBoundingCenter(pBody) : btVector3(0, 0, 0));
 

src/main/native/glue/vhacd4_Vhacd4.cpp

@@ -115,15 +115,17 @@ JNIEXPORT void JNICALL Java_vhacd4_Vhacd4_compute
     NULL_CHK(pEnv, pPositions, "The positions buffer is not direct.",);
     // no check for exceptions!
     const jlong capacityFloats = pEnv->GetDirectBufferCapacity(positionsBuffer);
-    EXCEPTION_CHK(pEnv,);
+    // no check for exceptions!
+    assert(capacityFloats != -1);
 
     NULL_CHK(pEnv, indicesBuffer, "The indices buffer does not exist.",);
     const jint * const pIndices
             = (jint *) pEnv->GetDirectBufferAddress(indicesBuffer);
     NULL_CHK(pEnv, pIndices, "The indices buffer is not direct.",);
     // no check for exceptions!
     const jlong capacityInts = pEnv->GetDirectBufferCapacity(indicesBuffer);
-    EXCEPTION_CHK(pEnv,);
+    // no check for exceptions!
+    assert(capacityFloats != -1);
 
     IVHACD::Parameters * const pParams
             = reinterpret_cast<IVHACD::Parameters *> (paramsId);

src/main/native/glue/vhacd4_Vhacd4Hull.cpp

@@ -33,6 +33,7 @@
 /*
  * Author: Stephen Gold
  */
+#include <cassert>
 #include "vhacd4_Vhacd4Hull.h"
 #include "jmeClasses.h"
 
@@ -75,7 +76,8 @@ JNIEXPORT void JNICALL Java_vhacd4_Vhacd4Hull_getPositions
     // no check for exceptions!
 
     const jlong capacityFloats = pEnv->GetDirectBufferCapacity(storeBuffer);
-    EXCEPTION_CHK(pEnv,);
+    // no check for exceptions!
+    assert(capacityFloats != -1);
     const uint32_t numPoints = pHull->m_points.size();
     for (uint32_t i = 0; i < numPoints; ++i) {
         const uint32_t bp = 3 * i;

src/main/native/glue/vhacd_VHACD.cpp

@@ -33,6 +33,7 @@
 /*
  * Author: Stephen Gold
  */
+#include <cassert>
 #ifndef NO_DEBUG
 #include <iostream>
 #endif
@@ -106,15 +107,17 @@ JNIEXPORT void JNICALL Java_vhacd_VHACD_compute
     NULL_CHK(pEnv, pPositions, "The positions buffer is not direct.",);
     // no check for exceptions!
     const jlong capacityFloats = pEnv->GetDirectBufferCapacity(positionsBuffer);
-    EXCEPTION_CHK(pEnv,);
+    // no check for exceptions!
+    assert(capacityFloats != -1);
 
     NULL_CHK(pEnv, indicesBuffer, "The indices buffer does not exist.",);
     const jint * const pIndices
             = (jint *) pEnv->GetDirectBufferAddress(indicesBuffer);
     NULL_CHK(pEnv, pIndices, "The indices buffer is not direct.",);
     // no check for exceptions!
     const jlong capacityInts = pEnv->GetDirectBufferCapacity(indicesBuffer);
-    EXCEPTION_CHK(pEnv,);
+    // no check for exceptions!
+    assert(capacityFloats != -1);
 
     IVHACD::Parameters * const pParams
             = reinterpret_cast<IVHACD::Parameters *> (paramsId);

src/main/native/glue/vhacd_VHACDHull.cpp

@@ -33,6 +33,7 @@
 /*
  * Author: Stephen Gold
  */
+#include <cassert>
 #include "vhacd_VHACDHull.h"
 #include "jmeClasses.h"
 #include "VHACD.h"
@@ -73,7 +74,8 @@ JNIEXPORT void JNICALL Java_vhacd_VHACDHull_getPositions
     // no check for exceptions!
 
     const jlong capacityFloats = pEnv->GetDirectBufferCapacity(storeBuffer);
-    EXCEPTION_CHK(pEnv,);
+    // no check for exceptions!
+    assert(capacityFloats != -1);
     const uint32_t numFloats = 3 * pHull->m_nPoints;
     for (uint32_t i = 0; i < numFloats && i < capacityFloats; ++i) {
         pPositions[i] = pHull->m_points[i];