glue: check return value of JNIEnv::NewGlobalRef(), no exception thrown

stephengold · stephengold · commit 060ea60882b9 · 2026-02-26T22:27:33.000-08:00
diff --git a/src/main/native/glue/cu/CustomBodyActivationListener.cpp b/src/main/native/glue/cu/CustomBodyActivationListener.cpp
@@ -43,7 +43,7 @@ class CustomBodyActivationListener : BodyActivationListener {
         pEnv->GetJavaVM(&mpVM);
 
         mJavaObject = pEnv->NewGlobalRef(javaObject);
-        EXCEPTION_CHECK(pEnv)
+        JPH_ASSERT(NULL != mJavaObject);
 
         const jclass clss = pEnv->FindClass(
                 "com/github/stephengold/joltjni/CustomBodyActivationListener");
diff --git a/src/main/native/glue/cu/CustomCastRayCollector.cpp b/src/main/native/glue/cu/CustomCastRayCollector.cpp
@@ -40,7 +40,7 @@ class CustomCastRayCollector : CastRayCollector {
         pEnv->GetJavaVM(&mpVM);
 
         mJavaObject = pEnv->NewGlobalRef(javaObject);
-        EXCEPTION_CHECK(pEnv)
+        JPH_ASSERT(NULL != mJavaObject);
 
         const jclass clss = pEnv->FindClass(
                 "com/github/stephengold/joltjni/CustomCastRayCollector");
diff --git a/src/main/native/glue/cu/CustomCastShapeBodyCollector.cpp b/src/main/native/glue/cu/CustomCastShapeBodyCollector.cpp
@@ -40,7 +40,7 @@ class CustomCastShapeBodyCollector : CastShapeBodyCollector {
         pEnv->GetJavaVM(&mpVM);
 
         mJavaObject = pEnv->NewGlobalRef(javaObject);
-        EXCEPTION_CHECK(pEnv)
+        JPH_ASSERT(NULL != mJavaObject);
 
         const jclass clss = pEnv->FindClass(
                 "com/github/stephengold/joltjni/CustomCastShapeBodyCollector");
diff --git a/src/main/native/glue/cu/CustomCastShapeCollector.cpp b/src/main/native/glue/cu/CustomCastShapeCollector.cpp
@@ -40,7 +40,7 @@ class CustomCastShapeCollector : CastShapeCollector {
         pEnv->GetJavaVM(&mpVM);
 
         mJavaObject = pEnv->NewGlobalRef(javaObject);
-        EXCEPTION_CHECK(pEnv)
+        JPH_ASSERT(NULL != mJavaObject);
 
         const jclass clss = pEnv->FindClass(
                 "com/github/stephengold/joltjni/CustomCastShapeCollector");
diff --git a/src/main/native/glue/cu/CustomCharacterContactListener.cpp b/src/main/native/glue/cu/CustomCharacterContactListener.cpp
@@ -50,7 +50,7 @@ class CustomCharacterContactListener : CharacterContactListener {
         pEnv->GetJavaVM(&mpVM);
 
         mJavaObject = pEnv->NewGlobalRef(javaObject);
-        EXCEPTION_CHECK(pEnv)
+        JPH_ASSERT(NULL != mJavaObject);
 
         const jclass clss = pEnv->FindClass(
                 "com/github/stephengold/joltjni/CustomCharacterContactListener");
diff --git a/src/main/native/glue/cu/CustomCollidePointCollector.cpp b/src/main/native/glue/cu/CustomCollidePointCollector.cpp
@@ -40,7 +40,7 @@ class CustomCollidePointCollector : CollidePointCollector {
         pEnv->GetJavaVM(&mpVM);
 
         mJavaObject = pEnv->NewGlobalRef(javaObject);
-        EXCEPTION_CHECK(pEnv)
+        JPH_ASSERT(NULL != mJavaObject);
 
         const jclass clss = pEnv->FindClass(
                 "com/github/stephengold/joltjni/CustomCollidePointCollector");
diff --git a/src/main/native/glue/cu/CustomCollideShapeBodyCollector.cpp b/src/main/native/glue/cu/CustomCollideShapeBodyCollector.cpp
@@ -40,7 +40,7 @@ class CustomCollideShapeBodyCollector : CollideShapeBodyCollector {
         pEnv->GetJavaVM(&mpVM);
 
         mJavaObject = pEnv->NewGlobalRef(javaObject);
-        EXCEPTION_CHECK(pEnv)
+        JPH_ASSERT(NULL != mJavaObject);
 
         const jclass clss = pEnv->FindClass(
                 "com/github/stephengold/joltjni/CustomCollideShapeBodyCollector");
diff --git a/src/main/native/glue/cu/CustomCollideShapeCollector.cpp b/src/main/native/glue/cu/CustomCollideShapeCollector.cpp
@@ -40,7 +40,7 @@ class CustomCollideShapeCollector : CollideShapeCollector {
         pEnv->GetJavaVM(&mpVM);
 
         mJavaObject = pEnv->NewGlobalRef(javaObject);
-        EXCEPTION_CHECK(pEnv)
+        JPH_ASSERT(NULL != mJavaObject);
 
         const jclass clss = pEnv->FindClass(
                 "com/github/stephengold/joltjni/CustomCollideShapeCollector");
diff --git a/src/main/native/glue/cu/CustomContactListener.cpp b/src/main/native/glue/cu/CustomContactListener.cpp
@@ -43,7 +43,7 @@ class CustomContactListener : ContactListener {
         pEnv->GetJavaVM(&mpVM);
 
         mJavaObject = pEnv->NewGlobalRef(javaObject);
-        EXCEPTION_CHECK(pEnv)
+        JPH_ASSERT(NULL != mJavaObject);
 
         const jclass clss = pEnv->FindClass(
                 "com/github/stephengold/joltjni/CustomContactListener");
diff --git a/src/main/native/glue/cu/CustomDebugRendererSimple.cpp b/src/main/native/glue/cu/CustomDebugRendererSimple.cpp
@@ -43,7 +43,7 @@ class CustomDebugRendererSimple : public DebugRendererSimple {
         pEnv->GetJavaVM(&mpVM);
 
         mJavaObject = pEnv->NewGlobalRef(javaObject);
-        EXCEPTION_CHECK(pEnv)
+        JPH_ASSERT(NULL != mJavaObject);
 
         const jclass clss = pEnv->FindClass(
                 "com/github/stephengold/joltjni/CustomDebugRendererSimple");
diff --git a/src/main/native/glue/cu/CustomPhysicsStepListener.cpp b/src/main/native/glue/cu/CustomPhysicsStepListener.cpp
@@ -40,7 +40,7 @@ class CustomPhysicsStepListener : PhysicsStepListener {
         pEnv->GetJavaVM(&mpVM);
 
         mJavaObject = pEnv->NewGlobalRef(javaObject);
-        EXCEPTION_CHECK(pEnv)
+        JPH_ASSERT(NULL != mJavaObject);
 
         const jclass clss = pEnv->FindClass(
                 "com/github/stephengold/joltjni/CustomPhysicsStepListener");
diff --git a/src/main/native/glue/cu/CustomRayCastBodyCollector.cpp b/src/main/native/glue/cu/CustomRayCastBodyCollector.cpp
@@ -40,7 +40,7 @@ class CustomRayCastBodyCollector : RayCastBodyCollector {
         pEnv->GetJavaVM(&mpVM);
 
         mJavaObject = pEnv->NewGlobalRef(javaObject);
-        EXCEPTION_CHECK(pEnv)
+        JPH_ASSERT(NULL != mJavaObject);
 
         const jclass clss = pEnv->FindClass(
                 "com/github/stephengold/joltjni/CustomRayCastBodyCollector");
diff --git a/src/main/native/glue/cu/CustomSoftBodyContactListener.cpp b/src/main/native/glue/cu/CustomSoftBodyContactListener.cpp
@@ -42,7 +42,7 @@ class CustomSoftBodyContactListener : SoftBodyContactListener {
         pEnv->GetJavaVM(&mpVM);
 
         mJavaObject = pEnv->NewGlobalRef(javaObject);
-        EXCEPTION_CHECK(pEnv)
+        JPH_ASSERT(NULL != mJavaObject);
 
         const jclass clss = pEnv->FindClass(
                 "com/github/stephengold/joltjni/CustomSoftBodyContactListener");
diff --git a/src/main/native/glue/d/Decomposer.cpp b/src/main/native/glue/d/Decomposer.cpp
@@ -44,7 +44,7 @@ class Decomposer : public IVHACD::IUserCallback, public IVHACD::IUserLogger {
         EXCEPTION_CHECK(pEnv)
 
         mJavaObject = pEnv->NewGlobalRef(javaObject);
-        EXCEPTION_CHECK(pEnv)
+        JPH_ASSERT(NULL != mJavaObject);
 
         const jclass clss = pEnv->FindClass(
                 "com/github/stephengold/joltjni/vhacd/Decomposer");
diff --git a/src/main/native/glue/f/FilteredContactListener.cpp b/src/main/native/glue/f/FilteredContactListener.cpp
@@ -63,7 +63,7 @@ class FilteredContactListener : ContactListener {
     FilteredContactListener(JNIEnv *pEnv, jobject javaObject) {
         pEnv->GetJavaVM(&mpVM);
         mJavaObject = pEnv->NewGlobalRef(javaObject);
-        EXCEPTION_CHECK(pEnv)
+        JPH_ASSERT(NULL != mJavaObject);
         const jclass clss = pEnv->FindClass(
                 "com/github/stephengold/joltjni/FilteredContactListener");
         JPH_ASSERT(NULL != clss);
diff --git a/src/main/native/glue/j/Jolt.cpp b/src/main/native/glue/j/Jolt.cpp
@@ -578,7 +578,8 @@ JNIEXPORT void JNICALL Java_com_github_stephengold_joltjni_Jolt_installJavaTrace
   (JNIEnv *pEnv, jclass, jobject stream) {
     pEnv->GetJavaVM(&gpVM);
     gTraceStream = pEnv->NewGlobalRef(stream);
-    EXCEPTION_CHECK(pEnv)
+    JPH_ASSERT(NULL != gTraceStream);
+    //
     const jclass clss = pEnv->FindClass("java/io/PrintStream");
     JPH_ASSERT(NULL != clss);
     EXCEPTION_CHECK(pEnv)
