changed vars to be parameters defaulting from puppet::master and added rspec tests

Author: crayfishx

manifests/masterenv.pp

@@ -18,13 +18,19 @@
 #       manifest               => 'dev'
 #   }
 #
-define  puppet::masterenv ($modulepath, $manifest, $puppet_conf = $::puppet::params::puppet_conf){
+define  puppet::masterenv (
+  $modulepath,
+  $manifest,
+  $puppet_conf = $::puppet::params::puppet_conf,
+  $environments = $::puppet::master::environments,
+  $environmentpath = $::puppet::master::environmentpath
+) {
 
-  case $::puppet::master::environments {
+  case $environments {
     'directory': {
-       $path = "${::puppet::master::environmentpath}/${name}/environment.conf"
+       $path = "${environmentpath}/${name}/environment.conf"
        $section = ''
-       file { "${::puppet::master::environmentpath}/${name}":
+       file { "${environmentpath}/${name}":
          ensure => directory,
        }
     }

spec/defines/puppet_masterenv_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe 'puppet::masterenv', :type => :define do
-  context "Create environment" do
+  context "Create config environment" do
     let :title do
       'dev'
     end
@@ -30,4 +30,38 @@
       )
     }
   end
+  context "Create directory environment" do
+    let :title do
+      'dev'
+    end
+
+    let :params do
+      {
+        :manifest        => '/etc/puppet/environments/dev.pp',
+        :modulepath      => '/etc/puppet/environments/modules/',
+        :puppet_conf     => '/etc/puppet/puppet.conf',
+        :environments    => 'directory',
+        :environmentpath => '/etc/puppet/environments'
+      }
+    end
+    it {
+      should contain_ini_setting("masterenvmodule#{title}").with(
+        :ensure  => 'present',
+        :section => '',
+        :setting => 'modulepath',
+        :path    => '/etc/puppet/environments/dev/environment.conf',
+        :value   => params[:modulepath]
+      )
+      should contain_ini_setting("masterenvmanifest#{title}").with(
+        :ensure  => 'present',
+        :section => '',
+        :setting => 'manifest',
+        :path    => '/etc/puppet/environments/dev/environment.conf',
+        :value   => params[:manifest]
+      )
+     should contain_file("/etc/puppet/environments/dev").with(
+       :ensure   => 'directory'
+     )
+    }
+  end
 end