Cleanup most of the missing variables for the rspec tests

Author: stephenrjohnson

spec/acceptance/master_spec.rb

@@ -1,50 +1,65 @@
 require 'spec_helper_acceptance'
 
 describe 'master tests:' do
-    context 'without puppetdb' do
-        it 'puppet::master class should work with no errors' do
-            pp = <<-EOS
+  context 'without puppetdb' do
+    let :facts do
+      {
+        :processorcount => '2'
+      }
+    end
+    it 'puppet::master class should work with no errors' do
+      pp = <<-EOS
                 class { 'puppet::master':}
-            EOS
+      EOS
 
-            # Run it twice and test for idempotency
-            apply_manifest(pp, :catch_failures => true)
-            #TODO fix me, should apply cleanly on one run
-            #apply_manifest(pp, :catch_changes => true)
-        end
+      # Run it twice and test for idempotency
+      apply_manifest(pp, :catch_failures => true)
+      #TODO fix me, should apply cleanly on one run
+      #apply_manifest(pp, :catch_changes => true)
     end
+  end
 
-    context 'with external puppetdb' do
-        it 'puppet::master class should work with no errors' do
-            pp = <<-EOS
+  context 'with external puppetdb' do
+    let :facts do
+      {
+        :processorcount => '2'
+      }
+    end
+    it 'puppet::master class should work with no errors' do
+      pp = <<-EOS
                 class { 'puppet::master':
                     storeconfigs               => true,
                     storeconfigs_dbserver      => 'puppetdb.foo.local',
                     puppetdb_strict_validation => false,
                 }
-            EOS
+      EOS
 
-            # Run it twice and test for idempotency
-            apply_manifest(pp, :catch_failures => true)
-            #TODO fix me, should apply cleanly on one run
-            #apply_manifest(pp, :catch_changes => true)
-        end
+      # Run it twice and test for idempotency
+      apply_manifest(pp, :catch_failures => true)
+      #TODO fix me, should apply cleanly on one run
+      #apply_manifest(pp, :catch_changes => true)
     end
+  end
 
-    # This test has to be after the non-puppetdb tests
-    context 'with puppetdb' do
-        it 'puppet::master class should work with no errors' do
-            pp = <<-EOS
+  # This test has to be after the non-puppetdb tests
+  context 'with puppetdb' do
+    let :facts do
+      {
+        :processorcount => '2'
+      }
+    end
+    it 'puppet::master class should work with no errors' do
+      pp = <<-EOS
                 class { 'puppetdb': }
                 class { 'puppet::master':
                     storeconfigs               => true,
                 }
-            EOS
+      EOS
 
-            # Run it twice and test for idempotency
-            apply_manifest(pp, :catch_failures => true)
-            #TODO fix me, should apply cleanly on one run
-            #apply_manifest(pp, :catch_changes => true)
-        end
+      # Run it twice and test for idempotency
+      apply_manifest(pp, :catch_failures => true)
+      #TODO fix me, should apply cleanly on one run
+      #apply_manifest(pp, :catch_changes => true)
     end
+  end
 end

spec/classes/puppet_master_spec.rb

@@ -9,6 +9,8 @@
                 :operatingsystem => 'Debian',
                 :operatingsystemrelease => '5',
                 :concat_basedir => '/nde',
+                :lsbdistcodename => 'lenny',
+                :processorcount => '2'
             }
         end
         let (:params) do
@@ -178,6 +180,7 @@
                 :operatingsystem => 'RedHat',
                 :operatingsystemrelease => '6',
                 :concat_basedir => '/nde',
+                :processorcount => '2'
             }
         end
         let (:params) do
@@ -344,6 +347,7 @@
                 :operatingsystem => 'RedHat',
                 :operatingsystemrelease => '6',
                 :concat_basedir => '/nde',
+                :processorcount => '2'
             }
         end
         let (:params) do {
@@ -376,6 +380,7 @@
                 :operatingsystem => 'RedHat',
                 :operatingsystemrelease => '6',
                 :concat_basedir => '/nde',
+                :processorcount => '2'
             }
         end
         let (:params) do {

spec/classes/puppet_passenger_spec.rb

@@ -24,6 +24,7 @@
                 :operatingsystem        => 'debian',
                 :operatingsystemrelease => '5',
                 :concat_basedir         => '/dne',
+                :lsbdistcodename        => 'lenny',
             }
         end
          it {

spec/classes/puppet_repo_puppetlabs_spec.rb

@@ -7,7 +7,7 @@
       {
         :osfamily        => 'Debian',
         :lsbdistcodename => 'Precise',
-        :lsbdistid       => 'Ubuntu'
+        :lsbdistid       => 'Ubuntu',
       }
     end
     it 'should contain puppetlabs apt repos' do

spec/defines/puppet_masterenv_spec.rb

@@ -5,6 +5,11 @@
     let :title do
       'dev'
     end
+    let :facts do
+      {
+        :processorcount => '2'
+      }
+    end
 
     let :params do
       {
@@ -34,6 +39,11 @@
     let :title do
       'dev'
     end
+    let :facts do
+      {
+        :processorcount => '2'
+      }
+    end
 
     let :params do
       {