add preferred_serialization_format and msgpack support

more information here https://docs.puppetlabs.com/puppet/latest/reference/experiments_msgpack.html#docs-»-experimental-features:-msgpack-support

add general support for preferred_serialization_format in master and agent, also install msgpack if needed

Author: Tim Meusel

manifests/agent.pp

@@ -27,6 +27,7 @@
 #   ['templatedir']           - Template dir, if unset it will remove the setting.
 #   ['configtimeout']         - How long the client should wait for the configuration to be retrieved before considering it a failure
 #   ['stringify_facts']       - Wether puppet transforms structured facts in strings or no. Defaults to true in puppet < 4, deprecated in puppet >=4 (and will default to false)
+#   ['serialization_format']  - defaults to undef, otherwise it sets the preferred_serialization_format param (currently only msgpack is supported)
 #
 # Actions:
 # - Install and configures the puppet agent
@@ -66,6 +67,7 @@
   $digest_algorithm       = $::puppet::params::digest_algorithm,
   $configtimeout          = '2m',
   $stringify_facts        = undef,
+  $serialization_format   = undef,
 ) inherits puppet::params {
 
   if ! defined(User[$::puppet::params::puppet_user]) {
@@ -187,6 +189,7 @@
       path    => $::puppet::params::puppet_conf,
       require => File[$::puppet::params::puppet_conf],
       section => 'agent',
+      ensure  => present,
   }
 
   if (($use_srv_records == true) and ($srv_domain == undef))
@@ -196,15 +199,13 @@
   elsif (($use_srv_records == true) and ($srv_domain != undef))
   {
     ini_setting {'puppetagentsrv_domain':
-      ensure  => present,
       setting => 'srv_domain',
       value   => $srv_domain,
     }
   }
   elsif($use_srv_records == false)
   {
     ini_setting {'puppetagentsrv_domain':
-      ensure  => absent,
       setting => 'srv_domain',
     }
   }
@@ -233,69 +234,57 @@
   }
 
   ini_setting {'puppetagentenvironment':
-    ensure  => present,
     setting => 'environment',
     value   => $environment,
   }
 
   ini_setting {'puppetagentmaster':
-    ensure  => present,
     setting => 'server',
     value   => $puppet_server,
   }
 
   ini_setting {'puppetagentuse_srv_records':
-    ensure  => present,
     setting => 'use_srv_records',
     value   => $use_srv_records,
   }
 
   ini_setting {'puppetagentruninterval':
-    ensure  => present,
     setting => 'runinterval',
     value   => $runinterval,
   }
 
   ini_setting {'puppetagentsplay':
-    ensure  => present,
     setting => 'splay',
     value   => $splay,
   }
 
   ini_setting {'puppetmasterport':
-    ensure  => present,
     setting => 'masterport',
     value   => $puppet_server_port,
   }
   ini_setting {'puppetagentreport':
-    ensure  => present,
     setting => 'report',
     value   => $report,
   }
   ini_setting {'puppetagentpluginsync':
-    ensure  => present,
     setting => 'pluginsync',
     value   => $pluginsync,
   }
   ini_setting {'puppetagentlisten':
-    ensure  => present,
     setting => 'listen',
     value   => $listen,
   }
   ini_setting {'puppetagentreportserver':
-    ensure  => present,
     setting => 'reportserver',
     value   => $reportserver,
   }
   ini_setting {'puppetagentdigestalgorithm':
-    ensure  => present,
     setting => 'digest_algorithm',
     value   => $digest_algorithm,
   }
   if ($templatedir != undef) and ($templatedir != 'undef')
   {
     ini_setting {'puppetagenttemplatedir':
-      ensure  => present,
       setting => 'templatedir',
       section => 'main',
       value   => $templatedir,
@@ -310,15 +299,28 @@
     }
   }
   ini_setting {'puppetagentconfigtimeout':
-    ensure  => present,
     setting => 'configtimeout',
     value   => $configtimeout,
   }
   if $stringify_facts != undef {
     ini_setting {'puppetagentstringifyfacts':
-      ensure  => present,
       setting => 'stringify_facts',
       value   => $stringify_facts,
     }
   }
+  if $serialization_format != undef {
+    if $serialization_format == 'msgpack' {
+      package {$::puppet::params::ruby_dev:
+        ensure  => 'latest',
+      } ->
+      package {'msgpack':
+        ensure  => 'latest',
+        provide => 'gem',
+      }
+    }
+    ini_setting {'puppetagentserializationformat':
+      setting => 'preferred_serialization_format',
+      value   => $serialization_format
+    }
+  }
 }

manifests/master.pp

@@ -33,6 +33,7 @@
 #  ['dns_alt_names']            - Comma separated list of alternative DNS names
 #  ['digest_algorithm']         - The algorithm to use for file digests.
 #  ['generate_ssl_certs']       - Generate ssl certs (false to disable)
+#  ['serialization_format']     - defaults to undef, otherwise it sets the preferred_serialization_format param (currently only msgpack is supported)
 #
 # Requires:
 #
@@ -87,6 +88,7 @@
   $digest_algorithm           = $::puppet::params::digest_algorithm,
   $generate_ssl_certs         = true,
   $puppetdb_version           = 'present',
+  $serialization_format       = undef,
 ) inherits puppet::params {
 
   anchor { 'puppet::master::begin': }
@@ -313,6 +315,20 @@
       setting => 'digest_algorithm',
       value   => $digest_algorithm,
   }
-
+  if $serialization_format != undef {
+    if $serialization_format == 'msgpack' {
+      package {$::puppet::params::ruby_dev:
+        ensure  => 'latest',
+      } ->
+      package {'msgpack':
+        ensure  => 'latest',
+        provide => 'gem',
+      }
+    }
+    ini_setting {'puppetagentserializationformat':
+      setting => 'preferred_serialization_format',
+      value   => $serialization_format
+    }
+  }
   anchor { 'puppet::master::end': }
 }

manifests/params.pp

@@ -47,6 +47,7 @@
       $puppet_ssldir                = '/var/lib/puppet/ssl'
       $passenger_package            = 'mod_passenger'
       $rack_package                 = 'rubygem-rack'
+      $ruby_dev                     = 'ruby-devel'
     }
     'Suse': {
       $puppet_master_package        = 'puppet-server'
@@ -70,6 +71,7 @@
       $puppet_ssldir                = '/var/lib/puppet/ssl'
       $passenger_package            = 'libapache2-mod-passenger'
       $rack_package                 = 'librack-ruby'
+      $ruby_dev                     = 'ruby-dev'
     }
     'FreeBSD': {
       $puppet_agent_service         = 'puppet'