Fix more tests

Author: simolus3

drift/lib/src/dsl/table.dart

@@ -509,7 +509,7 @@ class UseRowClass {
   ///
   /// For details, see the class documentation on [UseRowClass].
   const UseRowClass(this.type,
-      {this.constructor = '', this.generateInsertable = false});
+      {this.constructor = 'new', this.generateInsertable = false});
 }
 
 /// An annotation specifying view properties

drift_dev/lib/src/analysis/resolver/dart/helper.dart

@@ -7,7 +7,6 @@ import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/dart/element/type_provider.dart';
 import 'package:analyzer/dart/element/type_system.dart';
 import 'package:collection/collection.dart';
-import 'package:path/path.dart' as p;
 
 import '../../backend.dart';
 import '../../driver/error.dart';

drift_dev/lib/src/analysis/resolver/drift/element_resolver.dart

@@ -169,7 +169,7 @@ abstract class DriftElementResolver<T extends DiscoveredElement>
       return null;
     } else {
       return validateExistingClass(columns, foundDartClass,
-          source.constructorName ?? '', false, this, knownTypes);
+          source.constructorName ?? 'new', false, this, knownTypes);
     }
   }
 

drift_dev/lib/src/analysis/resolver/queries/existing_row_class.dart

@@ -199,8 +199,8 @@ class MatchExistingTypeForQuery {
         // into the classes' default constructor.
         final element = desiredType.element3;
 
-        final constructor = desiredType.lookUpConstructor2(
-            constructorName ?? '', element.library2);
+        final constructor =
+            desiredType.lookUpConstructor2(constructorName, element.library2);
         if (constructor == null) {
           if (constructorName == null) {
             reportError(

drift_dev/lib/src/analysis/resolver/shared/dart_types.dart

@@ -29,6 +29,10 @@ ExistingRowClass? validateExistingClass(
   LocalElementResolver step,
   KnownDriftTypes knownTypes,
 ) {
+  if (constructor == '') {
+    constructor = 'new';
+  }
+
   final desiredClass = dartClass.classElement;
   final library = desiredClass.library2;
   var isAsyncFactory = false;
@@ -95,7 +99,7 @@ ExistingRowClass? validateExistingClass(
   }
 
   if (ctor == null) {
-    final msg = constructor == ''
+    final msg = constructor == 'new'
         ? 'The desired data class must have an unnamed constructor'
         : 'The desired data class does not have a constructor named '
             '$constructor';

drift_dev/test/writer/writer_test.dart

@@ -2,7 +2,6 @@ import 'package:build/build.dart';
 import 'package:build_test/build_test.dart';
 import 'package:test/test.dart';
 
-import '../analysis/test_utils.dart';
 import '../utils.dart';
 
 void main() {
@@ -78,25 +77,17 @@ class Database {}
         ),
         contains(r'''
     return (
-      id:
-          attachedDatabase.typeMapping.read(
-            DriftSqlType.int,
-            data['${effectivePrefix}id'],
-          )!,
-      name:
-          attachedDatabase.typeMapping.read(
-            DriftSqlType.string,
-            data['${effectivePrefix}name'],
-          )!,
-      birthDate: attachedDatabase.typeMapping.read(
-        DriftSqlType.dateTime,
-        data['${effectivePrefix}birth_date'],
-      ),
+      id: attachedDatabase.typeMapping
+          .read(DriftSqlType.int, data['${effectivePrefix}id'])!,
+      name: attachedDatabase.typeMapping
+          .read(DriftSqlType.string, data['${effectivePrefix}name'])!,
+      birthDate: attachedDatabase.typeMapping
+          .read(DriftSqlType.dateTime, data['${effectivePrefix}birth_date']),
     );
 '''),
       ))
     }, result.dartOutputs, result.writer);
-  }, skip: requireDart('3.0.0-dev'));
+  });
 
   test(
     'references nullable variant of converter on non-nullable column',
@@ -265,9 +256,8 @@ class Database {}
 
       checkOutputs(
         {
-          'a|lib/a.drift.dart': decodedMatches(contains('Index(\n'
-              "    'users_name',\n"
-              "    'CREATE INDEX users_name ON users (name)',"))
+          'a|lib/a.drift.dart': decodedMatches(contains("Index('users_name', "
+              "'CREATE INDEX users_name ON users (name)'"))
         },
         result.dartOutputs,
         result.writer,