Skip to content

Commit 784ef06

Browse files
committed
disable code signing for macos
1 parent 250ffae commit 784ef06

File tree

2 files changed

+19
-22
lines changed

2 files changed

+19
-22
lines changed

.github/workflows/electron.yaml

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -66,41 +66,37 @@ jobs:
6666
if: matrix.os == 'macos-latest'
6767
run: echo "BUILD_ARGS=--universal" >> $GITHUB_ENV
6868

69-
- name: Check notarization credentials (Apple ID still valid)
70-
if: matrix.os == 'macos-latest'
71-
run: |
72-
xcrun notarytool history \
73-
--apple-id "$APPLE_ID" \
74-
--password "$APPLE_APP_SPECIFIC_PASSWORD" \
75-
--team-id "$APPLE_TEAM_ID"
76-
env:
77-
APPLE_ID: ${{ secrets.apple_id }}
78-
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.apple_app_specific_password }}
79-
APPLE_TEAM_ID: ${{ secrets.team_id }}
80-
8169
- name: Install Dependencies
8270
run: |
8371
cd launcher && npm i
8472
85-
- name: Build Electron app
73+
- name: Build Electron app (windows and linux)
8674
uses: samuelmeuli/action-electron-builder@v1
8775
with:
8876
github_token: ${{ secrets.github_token }}
8977
package_root: launcher
9078
use_vue_cli: true
9179
release: never
9280
build_script_name: dist
93-
mac_certs: ${{ secrets.mac_certs }}
94-
mac_certs_password: ${{ secrets.mac_certs_password }}
9581
args: ${{ env.BUILD_ARGS }}
9682
env:
97-
APPLE_ID: ${{ secrets.apple_id }}
98-
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.apple_app_specific_password }}
99-
TEAM_SHORT_NAME: ${{ secrets.team_short_name }}
100-
APP_ID: "com.stereum.launcher"
101-
APPLE_TEAM_ID: ${{ secrets.team_id }}
83+
NOTARIZE: "true"
10284
KEYPAIR_ALIAS: ${{ secrets.KEYPAIR_ALIAS }}
103-
if: ${{ !contains(github.event.head_commit.message, '[NOCI]') }}
85+
if: ${{ !contains(github.event.head_commit.message, '[NOCI]') && matrix.os != 'macos-latest' }}
86+
87+
- name: Build Electron app (macOS, unsigned)
88+
uses: samuelmeuli/action-electron-builder@v1
89+
with:
90+
github_token: ${{ secrets.github_token }}
91+
package_root: launcher
92+
use_vue_cli: true
93+
release: never
94+
build_script_name: dist
95+
args: ${{ env.BUILD_ARGS }}
96+
env:
97+
NOTARIZE: "false"
98+
CSC_IDENTITY_AUTO_DISCOVERY: "false"
99+
if: ${{ !contains(github.event.head_commit.message, '[NOCI]') && matrix.os == 'macos-latest'}}
104100

105101
- name: Verify Signing using Signtool on windows-latest
106102
run: |

launcher/vue.config.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
const shouldNotarize = process.env.NOTARIZE === "true";
12
module.exports = {
23
parallel: false,
34
pluginOptions: {
@@ -10,7 +11,7 @@ module.exports = {
1011
},
1112
appId: "com.stereum.launcher",
1213
productName: "Stereum-Launcher",
13-
afterSign: "@sapien99/vue-cli-plugin-electron-builder-notarize",
14+
...(shouldNotarize ? { afterSign: "@sapien99/vue-cli-plugin-electron-builder-notarize" } : {}),
1415
buildDependenciesFromSource: false,
1516
nodeGypRebuild: false,
1617
npmRebuild: false,

0 commit comments

Comments
 (0)