Disable Code Signing for MacOS (#2292)

* Update electron.yaml

* disable code signing for macos

* fix: small issue with jwt creation

Author: NeoPlays

.github/workflows/electron.yaml

@@ -70,25 +70,33 @@ jobs:
         run: |
           cd launcher && npm i
 
-      - name: Build Electron app
+      - name: Build Electron app (windows and linux)
         uses: samuelmeuli/action-electron-builder@v1
         with:
           github_token: ${{ secrets.github_token }}
           package_root: launcher
           use_vue_cli: true
           release: never
           build_script_name: dist
-          mac_certs: ${{ secrets.mac_certs }}
-          mac_certs_password: ${{ secrets.mac_certs_password }}
           args: ${{ env.BUILD_ARGS }}
         env:
-          APPLE_ID: ${{ secrets.apple_id }}
-          APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.apple_app_specific_password }}
-          TEAM_SHORT_NAME: ${{ secrets.team_short_name }}
-          APP_ID: "com.stereum.launcher"
-          APPLE_TEAM_ID: ${{ secrets.team_id }}
+          NOTARIZE: "true"
           KEYPAIR_ALIAS: ${{ secrets.KEYPAIR_ALIAS }}
-        if: ${{ !contains(github.event.head_commit.message, '[NOCI]') }}
+        if: ${{ !contains(github.event.head_commit.message, '[NOCI]') && matrix.os != 'macos-latest' }}
+
+      - name: Build Electron app (macOS, unsigned)
+        uses: samuelmeuli/action-electron-builder@v1
+        with:
+          github_token: ${{ secrets.github_token }}
+          package_root: launcher
+          use_vue_cli: true
+          release: never
+          build_script_name: dist
+          args: ${{ env.BUILD_ARGS }}
+        env:
+          NOTARIZE: "false"
+          CSC_IDENTITY_AUTO_DISCOVERY: "false"
+        if: ${{ !contains(github.event.head_commit.message, '[NOCI]') && matrix.os == 'macos-latest'}}
 
       - name: Verify Signing using Signtool on windows-latest
         run: |

controls/roles/manage-service/tasks/main.yml

@@ -109,7 +109,7 @@
         hex_chars: "0123456789abcdef"
       become: yes
       when:
-        - stereum_service_configuration.service in ['BesuService', 'GethService', 'RethService', 'NethermindService', 'ErigonService', 'LighthouseBeaconService', 'NimbusBeaconService', 'PrysmBeaconService', 'TekuBeaconService', 'LodestarBeaconService', 'OpGethService', 'OpErigonService', 'OpRethService']
+        - stereum_service_configuration.service in ['BesuService', 'GethService', 'RethService', 'NethermindService', 'ErigonService', 'LighthouseBeaconService', 'NimbusBeaconService', 'PrysmBeaconService', 'TekuBeaconService', 'LodestarBeaconService', 'OpGethService', 'OpErigonService', 'OpRethService', 'GrandineBeaconService', 'EthrexService']
         - stereum_service_configuration.volumes | select('search', ':/engine.jwt|/execution/engine.jwt|:/op-engine.jwt') | length > 0
 
     - include_tasks: write-graffiti-files.yml

launcher/vue.config.js

@@ -1,3 +1,4 @@
+const shouldNotarize = process.env.NOTARIZE === "true";
 module.exports = {
   parallel: false,
   pluginOptions: {
@@ -10,7 +11,7 @@ module.exports = {
         },
         appId: "com.stereum.launcher",
         productName: "Stereum-Launcher",
-        afterSign: "@sapien99/vue-cli-plugin-electron-builder-notarize",
+        ...(shouldNotarize ? { afterSign: "@sapien99/vue-cli-plugin-electron-builder-notarize" } : {}),
         buildDependenciesFromSource: false,
         nodeGypRebuild: false,
         npmRebuild: false,