Skip to content

Commit 00b519b

Browse files
committed
removed mysql
1 parent 8fd7804 commit 00b519b

File tree

5 files changed

+13
-34
lines changed

5 files changed

+13
-34
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -98,30 +98,6 @@ jobs:
9898
- name: Run tests with mariadb
9999
run: mvn test -pl core -am -Dspring.profiles.active=mariadb
100100

101-
test-mysql:
102-
runs-on: ubuntu-latest
103-
needs: build
104-
services:
105-
postgres:
106-
image: mysql:latest
107-
env:
108-
MYSQL_USER: sa
109-
MYSQL_ROOT_PASSWORD: veryStrong123
110-
MYSQL_PASSWORD: veryStrong123
111-
MYSQL_DATABASE: testdb
112-
ports:
113-
- 3306:3306
114-
steps:
115-
- uses: actions/checkout@v4
116-
- name: Set up JDK 21
117-
uses: actions/setup-java@v4
118-
with:
119-
java-version: '21'
120-
distribution: 'temurin'
121-
cache: maven
122-
- name: Run tests with mysql
123-
run: mvn test -pl core -am -Dspring.profiles.active=mysql
124-
125101
java-doc:
126102
runs-on: ubuntu-latest
127103
needs: [build]
@@ -153,7 +129,7 @@ jobs:
153129

154130
maven-deploy:
155131
runs-on: ubuntu-latest
156-
needs: [build, test-mssql, test-postgres, test-mariadb, test-mysql]
132+
needs: [build, test-mssql, test-postgres, test-mariadb]
157133
if: ${{ github.ref == 'refs/heads/main' }}
158134
steps:
159135
- uses: actions/checkout@v4

README.md

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,18 @@ Secondary goal is to support [Poor mans Workflow](https://github.com/sterlp/pmw)
1212

1313
## Tested in the pipeline
1414

15-
- H2
16-
- azure-sql-edge (MSSQL)
15+
- H2
16+
- azure-sql-edge (MSSQL)
17+
- PostgreSQL
18+
- MariaDB
1719

1820
## Supported in theory
1921

20-
- MSSQL
21-
- PostgreSQL
22-
- mySQL
23-
- MariaDB
22+
- MSSQL, as azure-sql-edge is tested
23+
24+
## Not supported
25+
26+
- mySQL: sequences are not supported
2427

2528
# Setup and Run a Task
2629

RUN_AND_BUILD.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ docker run --cap-add SYS_PTRACE -e 'ACCEPT_EULA=Y' -e 'MSSQL_SA_PASSWORD=veryStr
1212
docker run -e MYSQL_ROOT_PASSWORD=veryStrong123 -e MYSQL_DATABASE=testdb -e MYSQL_USER=sa -e MYSQL_PASSWORD=veryStrong123 -p 3306:3306 -d mariadb:latest
1313

1414
## MySQL
15-
docker run -e MYSQL_ROOT_PASSWORD=veryStrong123 -e MYSQL_DATABASE=testdb -e MYSQL_USER=sa -e MYSQL_PASSWORD=veryStrong123 -p 3306:3306 -d mysql:latest
15+
docker run -e MYSQL_ROOT_PASSWORD=veryStrong123 -e MYSQL_DATABASE=testdb -e MYSQL_USER=sa -e MYSQL_PASSWORD=veryStrong123 -p 3306:3306 -d mysql

core/src/test/java/org/sterl/spring/persistent_tasks/AbstractSpringTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
import uk.co.jemos.podam.api.PodamFactory;
3535
import uk.co.jemos.podam.api.PodamFactoryImpl;
3636

37-
//@ActiveProfiles("mariadb") // postgres mssql mariadb
37+
// @ActiveProfiles("mssql") // postgres mssql mariadb mysql
3838
@SpringBootTest(classes = SampleApp.class, webEnvironment = WebEnvironment.RANDOM_PORT)
3939
public class AbstractSpringTest {
4040

core/src/test/resources/application-mysql.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
spring:
22
datasource:
3-
username: sa
3+
username: root
44
password: veryStrong123
55
url: jdbc:mysql://localhost:3306/testdb
66
driver-class-name: com.mysql.jdbc.Driver

0 commit comments

Comments
 (0)