Skip to content

Commit 0e0202e

Browse files
committed
adjusted trigger cols that the ui does not break
1 parent 7abff9a commit 0e0202e

File tree

4 files changed

+20
-13
lines changed

4 files changed

+20
-13
lines changed

core/src/test/java/org/sterl/spring/persistent_tasks/task/TaskTransactionTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ void testRequiresNewHasOwnTransaction() {
134134

135135
@ParameterizedTest
136136
@ValueSource(strings = {"transactionalClass", "transactionalMethod", "transactionalClosure"})
137-
void testTransactionalTask(String task) {
137+
void testTransactionalTask(String task) throws InterruptedException {
138138
// GIVEN
139139
var t = triggerService.queue(TaskTriggerBuilder
140140
.newTrigger(task, "test").build());
@@ -143,7 +143,7 @@ void testTransactionalTask(String task) {
143143
personRepository.deleteAllInBatch();
144144
hibernateAsserts.reset();
145145
triggerService.run(t).get();
146-
146+
Thread.sleep(50); // TODO wait for the history running event
147147
// THEN
148148
hibernateAsserts.assertTrxCount(2);
149149
assertThat(personRepository.count()).isEqualTo(2);

example/src/main/java/org/sterl/spring/example_app/vehicle/VehicleService.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import java.time.OffsetDateTime;
44
import java.util.Random;
5+
import java.util.UUID;
56

67
import org.springframework.context.ApplicationEventPublisher;
78
import org.springframework.scheduling.annotation.Scheduled;
@@ -34,7 +35,10 @@ void triggerBuildVehicle() {
3435
v.setId(null);
3536
v.getEngine().setId(null);
3637

37-
eventPublisher.publishEvent(TriggerTaskCommand.of(BuildVehicleTask.ID.newUniqueTrigger(v)));
38+
eventPublisher.publishEvent(TriggerTaskCommand.of(BuildVehicleTask.ID
39+
.newTrigger(v)
40+
.id(UUID.randomUUID().toString() + UUID.randomUUID().toString())
41+
.build()));
3842

3943
eventPublisher.publishEvent(TriggerTaskCommand.of(BuildVehicleTask.ID.newTrigger().state(v)
4044
.runAt(OffsetDateTime.now().plusMinutes(RANDOM.nextInt(10_000))).build()));
@@ -48,6 +52,9 @@ public void buildVehicle(String type) {
4852
v.getEngine().setId(null);
4953
v.setType(type);
5054

51-
persistentTaskService.runOrQueue(BuildVehicleTask.ID.newUniqueTrigger(v));
55+
persistentTaskService.runOrQueue(BuildVehicleTask.ID
56+
.newTrigger(v)
57+
.id(UUID.randomUUID().toString() + UUID.randomUUID().toString())
58+
.build());
5259
}
5360
}

ui/src/shared/view/trigger-list-item.view.tsx

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import TriggerHistoryListView from "@src/history/view/trigger-history.view";
22
import { Trigger } from "@src/server-api";
33
import LabeledText from "@src/shared/view/labled-text.view";
44
import JsonView from "@uiw/react-json-view";
5-
import { Accordion, Button, Col, Container, Row } from "react-bootstrap";
5+
import { Accordion, Button, Col, Container, Form, Row } from "react-bootstrap";
66
import TriggerStatusView from "../../trigger/views/trigger-staus.view";
77
import { formatMs, formatShortDateTime } from "../date.util";
88
import { useServerObject } from "../http-request";
@@ -83,21 +83,22 @@ export default TriggerItemView;
8383

8484
const TriggerCompactView = ({ trigger }: { trigger: Trigger }) => (
8585
<Row className="align-items-center">
86-
<Col xs="3" xl="1">
86+
<Col className="col-2">
8787
<TriggerStatusView data={trigger} />
8888
</Col>
89-
<Col>
90-
<small className="text-truncate text-muted">{trigger.key.id}</small>
91-
<br />
92-
{" " + trigger.key.taskName}
89+
<Col className="col-5">
90+
<Form.Text muted role="label">
91+
{trigger.key.id}
92+
</Form.Text>
93+
<div>{trigger.key.taskName}</div>
9394
</Col>
94-
<Col>
95+
<Col className="col-2">
9596
<LabeledText
9697
label="Run at"
9798
value={formatShortDateTime(trigger.runAt)}
9899
/>
99100
</Col>
100-
<Col>
101+
<Col className="col-3">
101102
{trigger.runningOn ? (
102103
<LabeledText
103104
label={`Running on (${trigger.executionCount})`}

ui/src/trigger/triggers.page.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ const TriggersPage = () => {
2020
"?size=10&" + new URLSearchParams(query).toString()
2121
);
2222
};
23-
console.info(query);
2423
useAutoRefresh(10000, doReload, [query]);
2524

2625
return (

0 commit comments

Comments
 (0)