Skip to content

Commit 1ef67ae

Browse files
committed
cleanup
1 parent 406ccda commit 1ef67ae

File tree

5 files changed

+13
-5
lines changed

5 files changed

+13
-5
lines changed

core/src/main/java/org/sterl/spring/persistent_tasks/shared/model/HasTrigger.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ default TaskId<Serializable> newTaskId() {
2828
}
2929

3030
default boolean shouldRunInFuture() {
31-
if (getData().getRunAt() == null) return true;
31+
if (status() == TriggerStatus.AWAITING_SIGNAL) return true;
32+
if (getData().getRunAt() == null) return false;
3233
return getData().getRunAt().toInstant().toEpochMilli() > System.currentTimeMillis();
3334
}
3435
}

core/src/main/java/org/sterl/spring/persistent_tasks/trigger/component/FailTriggerComponent.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,15 +62,21 @@ private <T extends Serializable> Optional<RunningTriggerEntity> triggerFailed(
6262
final var retryAt = determineWhenToRetry(task, trigger, e);
6363
var result = editTrigger.failTrigger(trigger.getKey(), state, e, retryAt);
6464

65+
invokeTriggerErrorCallback(task, retryAt, state, e);
66+
67+
return result;
68+
}
69+
70+
private <T extends Serializable> void invokeTriggerErrorCallback(
71+
PersistentTask<T> task,
72+
final OffsetDateTime retryAt, T state, Exception e) {
6573
if (task != null && retryAt == null) {
6674
try {
6775
task.afterTriggerFailed(state, e);
6876
} catch (Exception ex) {
6977
log.error("Failed to invoke afterTriggerFailed on {}", task.getClass(), e);
7078
}
7179
}
72-
73-
return result;
7480
}
7581

7682
/**

doc/docs/assets/dashboard.png

163 KB
Loading

doc/docs/index.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ A simple task management framework designed to queue and execute asynchronous ta
66

77
Focus is the usage with spring boot and JPA.
88

9+
![Dashboard](./assets/dashboard.png)
10+
911
## Key Features ✨
1012

1113
1. **JPA-Powered Persistence** - Automatically persists tasks to your database

doc/mkdocs.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
site_name: Spring Persistent Tasks
2+
site_url: https://spring-persistent-task.sterl.org
23
theme:
34
name: material
45
features:
56
- content.code.copy
67
- content.code.annotate
78
plugins:
89
- search
9-
- sitemap:
10-
site_url: https://spring-persistent-task.sterl.org
1110
- tags
1211
- glightbox
1312
markdown_extensions:

0 commit comments

Comments
 (0)