cleanup

Author: sterlp

example/src/main/resources/application-mssql.yml

@@ -8,4 +8,4 @@ spring:
       maximum-pool-size: 100
   jpa:
     hibernate:
-      ddl-auto: update
+      ddl-auto: create-drop

example/src/test/java/org/sterl/spring/persistent_tasks/example/ExampleApplicationTests.java renamed to example/src/test/java/org/sterl/spring/example_app/ExampleApplicationTests.java

@@ -1,4 +1,4 @@
-package org.sterl.spring.persistent_tasks.example;
+package org.sterl.spring.example_app;
 
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;

pom.xml

@@ -105,7 +105,10 @@
                         <target>${java.version}</target>
                         <encoding>${project.reporting.outputEncoding}</encoding>
                         <compilerArgs>
-                            <arg>-Xlint:all,-options,-path,-parameters</arg>
+                            <arg>-Xlint:all</arg>
+                            <arg>-Xlint:-options</arg>
+                            <arg>-Xlint:-path</arg>
+                            <arg>-parameters</arg>
                         </compilerArgs>
                     </configuration>
                 </plugin>
@@ -122,8 +125,7 @@
                         <failOnViolation>true</failOnViolation>
                         <printFailingErrors>true</printFailingErrors>
                         <analysisCache>true</analysisCache>
-                        <analysisCacheLocation>
-                            ${project.build.directory}/pmd/pmd.cache</analysisCacheLocation>
+                        <analysisCacheLocation>${project.build.directory}/pmd/pmd.cache</analysisCacheLocation>
                     </configuration>
                     <executions>
                         <execution>

spring-persistent-tasks-db/src/test/java/org/sterl/spring/persistent_tasks/db/ApplyLiquibaseTest.java

@@ -1,6 +1,7 @@
 package org.sterl.spring.persistent_tasks.db;
 
-import java.util.List;
+import static org.assertj.core.api.Assertions.assertThat;
+
 import java.util.Map;
 
 import javax.sql.DataSource;
@@ -19,7 +20,7 @@ class ApplyLiquibaseTest {
 
     @Test
     void test() throws Exception {
-        var dataSource = mssqlDb();
+        var dataSource = h2Db();
         try (Database database = DatabaseFactory.getInstance()
                 .findCorrectDatabaseImplementation(
                         new liquibase.database.jvm.JdbcConnection(dataSource.getConnection()))) {
@@ -40,10 +41,28 @@ void test() throws Exception {
         }
 
         var template = new JdbcTemplate(dataSource);
-        final List<Map<String, Object>> var = template.queryForList("SHOW TABLES");
-        for (Map<String, Object> map : var) {
+        final var tables = template.queryForList("SHOW TABLES");
+        for (Map<String, Object> map : tables) {
             System.err.println(map);
         }
+        assertThat(tables).contains(
+                Map.of("TABLE_NAME", "PT_DATABASECHANGELOG", 
+                        "TABLE_SCHEMA", "PUBLIC"));
+        assertThat(tables).contains(
+                Map.of("TABLE_NAME", "PT_DATABASECHANGELOGLOCK", 
+                        "TABLE_SCHEMA", "PUBLIC"));
+        assertThat(tables).contains(
+                Map.of("TABLE_NAME", "PT_SCHEDULER", 
+                        "TABLE_SCHEMA", "PUBLIC"));
+        assertThat(tables).contains(
+                Map.of("TABLE_NAME", "PT_TASK_TRIGGERS", 
+                        "TABLE_SCHEMA", "PUBLIC"));
+        assertThat(tables).contains(
+                Map.of("TABLE_NAME", "PT_TRIGGER_HISTORY_DETAILS", 
+                        "TABLE_SCHEMA", "PUBLIC"));
+        assertThat(tables).contains(
+                Map.of("TABLE_NAME", "PT_TRIGGER_HISTORY_LAST_STATES", 
+                        "TABLE_SCHEMA", "PUBLIC"));
     }
 
     private JdbcDataSource h2Db() {

spring-persistent-tasks-ui/src/shared/http-error.view.tsx

@@ -1,4 +1,4 @@
-import { Alert, Col, Row } from "react-bootstrap";
+import { Alert } from "react-bootstrap";
 
 const HttpErrorView = ({ error }: { error: any }) => {
     if (!error) return undefined;

spring-persistent-tasks/pom.xml

@@ -45,6 +45,7 @@
             <groupId>${project.groupId}</groupId>
             <artifactId>spring-persistent-tasks-db</artifactId>
             <version>${project.version}</version>
+            <scope>test</scope>
         </dependency>
 
         <dependency>

spring-persistent-tasks/src/test/java/org/sterl/spring/persistent_tasks/trigger/TriggerServiceTest.java

@@ -6,6 +6,7 @@
 import java.time.OffsetDateTime;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Optional;
 import java.util.concurrent.Callable;
 import java.util.concurrent.Executors;
 
@@ -256,7 +257,7 @@ void testLockTrigger() throws Exception {
             }
 
             // WHEN
-            ArrayList<Callable<?>> lockInvocations = new ArrayList<>();
+            ArrayList<Callable<Optional<TriggerEntity> >> lockInvocations = new ArrayList<>();
             for (int i = 1; i <= 100; ++i) {
                 lockInvocations.add(() -> runNextTrigger());
             }