fixed page view test

Author: sterlp

ui/spt-ui-lib/lib/shared/view/page.view.tsx

@@ -10,7 +10,6 @@ interface PageViewProps {
 const PageView: React.FC<PageViewProps> = ({ data, onPage }) => {
     if (!data) return undefined;
 
-    const isDataAvailable = !!data && !!data.content;
     const currentPage = data?.page.number ?? 0;
     const totalPages = data?.page.totalPages ?? 0;
     const totalElements = data?.page.totalElements ?? 0;
@@ -29,22 +28,22 @@ const PageView: React.FC<PageViewProps> = ({ data, onPage }) => {
         }
     };
 
-    const displayCount = isDataAvailable
-        ? `${contentLength + pageSize * currentPage} / ${totalElements}`
-        : "-";
+    const displayCount = `${
+        contentLength + pageSize * currentPage
+    } / ${totalElements}`;
 
     return (
         <Pagination className="mb-0 mt-0 d-felx align-items-center justify-content-center">
             <Pagination.Prev
                 data-testid="prev"
                 onClick={handlePrevClick}
-                disabled={!isDataAvailable || currentPage === 0}
+                disabled={currentPage === 0}
             />
             <strong className="ms-2 me-2">{displayCount}</strong>
             <Pagination.Next
                 data-testid="next"
                 onClick={handleNextClick}
-                disabled={!isDataAvailable || currentPage >= totalPages - 1}
+                disabled={currentPage >= totalPages - 1}
             />
         </Pagination>
     );

ui/spt-ui-lib/test/shared/view/page.view.test.tsx

@@ -13,16 +13,12 @@ describe("PageView Component", () => {
         mockOnPage.mockClear();
     });
 
-    it("No data: should disable both buttons and display '-'", () => {
+    it("No data: pager should not be rendered", () => {
         renderComponent(undefined);
 
-        expect(screen.getByText("-")).toBeInTheDocument();
-        expect(screen.getByTestId("next").closest("li")).toHaveClass(
-            "disabled"
-        );
-        expect(screen.getByTestId("prev").closest("li")).toHaveClass(
-            "disabled"
-        );
+        expect(screen.queryByText("-")).not.toBeInTheDocument();
+        expect(screen.queryByTestId("next")).not.toBeInTheDocument();
+        expect(screen.queryByTestId("prev")).not.toBeInTheDocument();
     });
 
     it("Middle page: should enable both Prev and Next", () => {
@@ -31,7 +27,7 @@ describe("PageView Component", () => {
             content: new Array(10),
         });
 
-        expect(screen.getByText("20 / 30")).toBeInTheDocument();
+        expect(screen.queryByText("20 / 30")).toBeInTheDocument();
         expect(
             screen.getByRole("button", { name: "Previous" })
         ).not.toBeDisabled();
@@ -50,7 +46,7 @@ describe("PageView Component", () => {
             content: [],
         });
 
-        expect(screen.getByText("0 / 10")).toBeInTheDocument();
+        expect(screen.queryByText("0 / 10")).toBeInTheDocument();
         expect(screen.getByTestId("next").closest("li")).toHaveClass(
             "disabled"
         );