cancel trigger is now always possible

Author: sterlp

CHANGELOG.md

@@ -1,10 +1,16 @@
 # Changelog
 
-## v1.6.4  - (2025-03-19)
+## v1.6.5  - (2025-03-19)
+
+-   fixed correlation ID size
+-   cancel can now always be triggered from the UI
+-   showing slow used history
+
+## v1.6.4  - (2025-03-18)
 
 -   in tests the task executor may finish a task before it returns it reference
 
-## v1.6.3  - (2025-03-19)
+## v1.6.3  - (2025-03-18)
 
 -   ensure the remove of a running trigger happens after it is added
 

core/src/main/java/org/sterl/spring/persistent_tasks/api/task/RunningTriggerContextHolder.java

@@ -37,11 +37,6 @@ public static String getCorrelationId() {
     public static String buildOrGetCorrelationId(String newCorrelationId) {
         var correlationId = getCorrelationId();
         if (correlationId == null) correlationId = newCorrelationId;
-        // take over any key from the trigger before ...
-        if (correlationId == null) {
-            var c = getContext();
-            if (c != null) correlationId = c.getKey().getId();
-        }
         return correlationId;
     }
 }

core/src/main/java/org/sterl/spring/persistent_tasks/trigger/api/TriggerResource.java

@@ -49,7 +49,7 @@ public PagedModel<Trigger> list(
     }
 
     @PostMapping("triggers/{taskName}/{id}/run-at")
-    public Optional<Trigger> cancelTrigger(
+    public Optional<Trigger> setRunAt(
             @PathVariable("taskName") String taskName,
             @PathVariable("id") String id,
             @RequestBody OffsetDateTime runAt) {

db/src/main/resources/spring-persistent-tasks/db/pt-changelog-v4.xml

@@ -0,0 +1,15 @@
+<?xml version="1.1" encoding="UTF-8" standalone="no"?>
+<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+    xmlns:ext="http://www.liquibase.org/xml/ns/dbchangelog-ext"
+    xmlns:pro="http://www.liquibase.org/xml/ns/pro"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog-ext http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-ext.xsd
+                        http://www.liquibase.org/xml/ns/pro http://www.liquibase.org/xml/ns/pro/liquibase-pro-latest.xsd
+                        http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd">
+
+    <changeSet author="sterlp" id="2025-03-19-correlation-id-update">
+        <modifyDataType tableName="pt_task_triggers" columnName="correlation_id" newDataType="varchar(200)" />
+        <modifyDataType tableName="pt_trigger_history_details" columnName="correlation_id" newDataType="varchar(200)" />
+        <modifyDataType tableName="pt_trigger_history_last_states" columnName="correlation_id" newDataType="varchar(200)" />
+    </changeSet>
+</databaseChangeLog>

ui/src/scheduler/views/scheduler.view.tsx

@@ -32,7 +32,7 @@ const SchedulerStatusView = ({ scheduler }: Props) => {
                 return [
                     ...prev.slice(-10), // Keep only the last 14 entries
                     {
-                        time: new Date().toLocaleTimeString(), // Format timestamp
+                        time: new Date(scheduler.lastPing).toLocaleTimeString(), // Format timestamp
                         tasks: scheduler.runningTasks ?? 0, // Running tasks
                         ping: scheduler.lastPing,
                     },

ui/src/shared/view/trigger-list-item.view.tsx

@@ -87,19 +87,19 @@ const TriggerItemView = ({
                             >
                                 Run now
                             </Button>
-                            <Button
-                                variant="danger"
-                                onClick={() => {
-                                    editTrigger
-                                        .doCall("", "DELETE")
-                                        .then(afterTriggerChanged)
-                                        .catch((e) => console.info(e));
-                                }}
-                            >
-                                Cancel Trigger
-                            </Button>
                         </>
                     ) : undefined}
+                    <Button
+                        variant="danger"
+                        onClick={() => {
+                            editTrigger
+                                .doCall("", "DELETE")
+                                .then(afterTriggerChanged)
+                                .catch((e) => console.info(e));
+                        }}
+                    >
+                        Cancel Trigger
+                    </Button>
                     {showReRunButton ? (
                         <Button
                             variant="warning"