added test to count the transactions

Author: sterlp

core/src/main/java/org/sterl/spring/persistent_tasks/task/model/RegisteredTask.java

@@ -38,4 +38,8 @@ public void accept(T state) {
     public RetryStrategy retryStrategy() {
         return this.fun.retryStrategy();
     }
+    @Override
+    public boolean isTransactional() {
+        return this.fun.isTransactional();
+    }
 }

core/src/test/java/org/sterl/spring/persistent_tasks/AbstractSpringTest.java

@@ -15,7 +15,6 @@
 import org.springframework.context.annotation.Configuration;
 import org.springframework.context.annotation.Primary;
 import org.springframework.stereotype.Component;
-import org.springframework.test.context.ActiveProfiles;
 import org.springframework.transaction.support.TransactionTemplate;
 import org.sterl.spring.persistent_tasks.api.SpringBeanTask;
 import org.sterl.spring.persistent_tasks.api.TaskId;
@@ -30,6 +29,7 @@
 import org.sterl.spring.sample_app.SampleApp;
 import org.sterl.test.AsyncAsserts;
 
+import jakarta.persistence.EntityManager;
 import lombok.RequiredArgsConstructor;
 import uk.co.jemos.podam.api.PodamFactory;
 import uk.co.jemos.podam.api.PodamFactoryImpl;
@@ -63,6 +63,8 @@ public class AbstractSpringTest {
     protected TransactionTemplate trx;
     @Autowired
     protected AsyncAsserts asserts;
+    @Autowired
+    protected HibernateAsserts hibernateAsserts;
 
     protected final PodamFactory pm = new PodamFactoryImpl();
 
@@ -72,6 +74,11 @@ public static class TaskConfig {
         AsyncAsserts asserts() {
             return new AsyncAsserts();
         }
+        
+        @Bean
+        HibernateAsserts hibernateAsserts(EntityManager entityManager) {
+            return new HibernateAsserts(entityManager);
+        }
 
         @Primary
         @Bean("schedulerA")
@@ -147,6 +154,7 @@ protected Optional<TriggerEntity> runNextTrigger() {
 
     @BeforeEach
     public void beforeEach() throws Exception {
+        hibernateAsserts.reset();
         triggerService.deleteAll();
         historyService.deleteAll();
         asserts.clear();

core/src/test/java/org/sterl/spring/persistent_tasks/HibernateAsserts.java

@@ -0,0 +1,48 @@
+package org.sterl.spring.persistent_tasks;
+
+import static org.junit.jupiter.api.Assertions.fail;
+
+import org.hibernate.Session;
+import org.hibernate.SessionFactory;
+import org.hibernate.stat.Statistics;
+
+import jakarta.persistence.EntityManager;
+
+public class HibernateAsserts {
+    private final Statistics statistics;
+
+    public HibernateAsserts(EntityManager entityManager) {
+        try (Session session = entityManager.unwrap(org.hibernate.Session.class)) {
+            @SuppressWarnings("resource")
+            SessionFactory factory = session.getSessionFactory();
+            factory.getStatistics().setStatisticsEnabled(true);
+            statistics = factory.getStatistics();
+        }
+    }
+
+    public HibernateAsserts assertTrxCount(int expected) {
+        long value = statistics.getTransactionCount();
+        if (value != expected) {
+            logSummary();
+            fail("Expected " + expected + " TransactionCount, but found " + value);
+        }
+        return this;
+    }
+
+    public HibernateAsserts assertInsertCount(int expected) {
+        long value = statistics.getEntityInsertCount();
+        if (value != expected) {
+            logSummary();
+            fail("Expected " + expected + " EntityInsertCount, but found " + value);
+        }
+        return this;
+    }
+
+    public void reset() {
+        statistics.clear();
+    }
+
+    public void logSummary() {
+        statistics.logSummary();
+    }
+}

core/src/test/java/org/sterl/spring/persistent_tasks/scheduler/SchedulerServiceTransactionTest.java

@@ -23,17 +23,14 @@
 class SchedulerServiceTransactionTest extends AbstractSpringTest {
 
     private SchedulerService subject;
-    @Autowired private AtomicBoolean sendError;
+    private static AtomicBoolean sendError = new AtomicBoolean(false);
+    private static AtomicBoolean inTrx = new AtomicBoolean(false);
     @Autowired private PersonRepository personRepository;
 
     @Configuration
     static class Config {
         @Bean
-        AtomicBoolean sendError() {
-            return new AtomicBoolean(false);
-        }
-        @Bean
-        SpringBeanTask<String> savePerson(PersonRepository personRepository, AtomicBoolean sendError) {
+        SpringBeanTask<String> savePerson(PersonRepository personRepository) {
             return new SpringBeanTask<>() {
                 @Transactional
                 @Override
@@ -46,6 +43,10 @@ public void accept(String name) {
                 public RetryStrategy retryStrategy() {
                     return RetryStrategy.THREE_RETRIES_IMMEDIATELY;
                 }
+                @Override
+                public boolean isTransactional() {
+                    return inTrx.get();
+                }
             };
         }
     }
@@ -56,17 +57,55 @@ public void beforeEach() throws Exception {
         subject = schedulerService;
         personRepository.deleteAllInBatch();
         sendError.set(false);
+        inTrx.set(false);
     }
-
+    
     @Test
     void testSaveEntity() throws Exception {
         // GIVEN
         final var trigger = TaskTriggerBuilder.newTrigger("savePerson").state("Paul").build();
 
         // WHEN
+        hibernateAsserts.reset();
         subject.runOrQueue(trigger).get();
 
         // THEN
+        // AND one the service, one the event and one more status update, 
+        // one more to save the trigger
+        hibernateAsserts.assertTrxCount(4);
+        assertThat(personRepository.count()).isOne();
+    }
+
+    @Test
+    void testSaveTransactions() throws Exception {
+        // GIVEN
+        final var request = TaskTriggerBuilder.newTrigger("savePerson").state("Paul").build();
+        var trigger = triggerService.queue(request);
+
+        // WHEN
+        hibernateAsserts.reset();
+        triggerService.run(trigger);
+
+        // THEN
+        // AND one the service, one the event and one more status update
+        hibernateAsserts.assertTrxCount(3);
+        assertThat(personRepository.count()).isOne();
+    }
+
+    
+    @Test
+    void testTrxCountTriggerService() throws Exception {
+        // GIVEN
+        final var request = TaskTriggerBuilder.newTrigger("savePerson").state("Paul").build();
+        var trigger = triggerService.queue(request);
+        inTrx.set(true);
+
+        // WHEN
+        hibernateAsserts.reset();
+        triggerService.run(trigger);
+
+        // THEN
+        hibernateAsserts.assertTrxCount(1);
         assertThat(personRepository.count()).isOne();
     }
 

core/src/test/java/org/sterl/spring/sample_app/component/EditSchedulerStatusComponentTest.java renamed to core/src/test/java/org/sterl/spring/persistent_tasks/scheduler/component/EditSchedulerStatusComponentTest.java

@@ -1,4 +1,4 @@
-package org.sterl.spring.sample_app.component;
+package org.sterl.spring.persistent_tasks.scheduler.component;
 
 import static org.assertj.core.api.Assertions.assertThat;