- not doing double conversion on array index

rominator1983 · rominator1983 · commit 1474cdc1deeb · 2022-02-18T22:14:24.000+01:00
diff --git a/ClosedXML/Excel/CalcEngine/Functions/Tally.cs b/ClosedXML/Excel/CalcEngine/Functions/Tally.cs
@@ -76,17 +76,18 @@ public double Median()
 
             if (nums.Length == 0) throw new ApplicationException("No values");
 
-            bool hasEvenCount = nums.Length % 2 == 0;
+            var hasEvenCount = nums.Length % 2 == 0;
+
             if (hasEvenCount)
             {
-                int numElementsToSkip = (nums.Length / 2) - 1;
+                var numElementsToSkip = (nums.Length / 2) - 1;
 
                 return nums.Skip(numElementsToSkip)
                            .Take(2)
                            .Average();
             }
 
-            int medianIndex = (int)Math.Floor(nums.Length / 2d);
+            var medianIndex = (nums.Length - 1) / 2;
 
             return nums[medianIndex];
         }

Original file line number	Diff line number	Diff line change
`@@ -76,17 +76,18 @@ public double Median()`
`76`	`76`
`77`	`77`	`if (nums.Length == 0) throw new ApplicationException("No values");`
`78`	`78`
`79`		`- bool hasEvenCount = nums.Length % 2 == 0;`
	`79`	`+ var hasEvenCount = nums.Length % 2 == 0;`
	`80`	`+`
`80`	`81`	`if (hasEvenCount)`
`81`	`82`	`{`
`82`		`- int numElementsToSkip = (nums.Length / 2) - 1;`
	`83`	`+ var numElementsToSkip = (nums.Length / 2) - 1;`
`83`	`84`
`84`	`85`	`return nums.Skip(numElementsToSkip)`
`85`	`86`	`.Take(2)`
`86`	`87`	`.Average();`
`87`	`88`	`}`
`88`	`89`
`89`		`- int medianIndex = (int)Math.Floor(nums.Length / 2d);`
	`90`	`+ var medianIndex = (nums.Length - 1) / 2;`
`90`	`91`
`91`	`92`	`return nums[medianIndex];`
`92`	`93`	`}`